[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] checkpatch: Fix newline detection in error_
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/4] checkpatch: Fix newline detection in error_setg() & friends |
|
Date: |
Thu, 4 Aug 2016 14:49:45 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 08/03/2016 05:37 AM, Markus Armbruster wrote:
> Commit 5d596c2's regexp assumes the error message string is the first
> argument. Correct for error_report(), wrong for all the others.
> Relax the regexp to match newline in anywhere. This might cause
> additional false positives.
Might, but those are still rare enough that we don't have to worry about
it unless someone actually hits such a false positive.
>
> While there, update the list of error_reporting functions.
>
> Cc: Jason J. Herne <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> scripts/checkpatch.pl | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature