[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/2] virtio-blk: Release s->rq queue at syste
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/2] virtio-blk: Release s->rq queue at system_reset |
Date: |
Tue, 2 Aug 2016 13:00:35 -0400 (EDT) |
> I'd prefer if Paolo's remark (about blk_drain()'s ability to produce
> more failed requests, stashed in s->rq) were captured in either the
> commit message, or in a code comment. Something like:
>
> /* We drop queued requests after blk_drain() because blk_drain()
> * itself can produce them. */
It's also (perhaps especially) because blk_drain() can consume them. Fam's
patch to do blk_drain() first would cause a double-free.
Paolo
> What do you think? It's your call. I certainly lacked that bit of
> information.
>
> Reviewed-by: Laszlo Ersek <address@hidden>
>
> Thanks!
> Laszlo
>
[Qemu-devel] [PATCH v2 2/2] virtio-blk: Remove stale comment about draining, Fam Zheng, 2016/08/02