[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Patch v1 15/29] s390x/sclp: indicate sclp features
From: |
David Hildenbrand |
Subject: |
Re: [Qemu-devel] [Patch v1 15/29] s390x/sclp: indicate sclp features |
Date: |
Tue, 2 Aug 2016 15:00:51 +0200 |
> > +void s390_get_feat_block(S390FeatType type, uint8_t *data)
> > +{
> > + static S390CPU *cpu;
> > +
> > + if (!cpu) {
> > + cpu = S390_CPU(qemu_get_cpu(0));
> > + }
> > +
> > + if (!cpu || !cpu->model) {
> > + return;
> > + }
> > + return s390_fill_feat_block(cpu->model->features, type, data);
>
> IMHO it's somewhat strange to write "return something()" in a function
> that has been declared as "void". I know GCC does not reject this, but
> anyway, I'd suggest to simply remove the "return" keyword here.
>
> Thomas
Yes, that looks like a leftover, thanks Thomas!
David
- Re: [Qemu-devel] [Patch v1 01/29] qmp: details about CPU definitions in query-cpu-definitions, (continued)
- Re: [Qemu-devel] [Patch v1 01/29] qmp: details about CPU definitions in query-cpu-definitions, Eduardo Habkost, 2016/08/02
- Re: [Qemu-devel] [Patch v1 01/29] qmp: details about CPU definitions in query-cpu-definitions, David Hildenbrand, 2016/08/02
- Re: [Qemu-devel] [Patch v1 01/29] qmp: details about CPU definitions in query-cpu-definitions, Eduardo Habkost, 2016/08/02
- Re: [Qemu-devel] [Patch v1 01/29] qmp: details about CPU definitions in query-cpu-definitions, David Hildenbrand, 2016/08/02
- Re: [Qemu-devel] [Patch v1 01/29] qmp: details about CPU definitions in query-cpu-definitions, Eduardo Habkost, 2016/08/02
- Re: [Qemu-devel] [Patch v1 01/29] qmp: details about CPU definitions in query-cpu-definitions, David Hildenbrand, 2016/08/02
[Qemu-devel] [Patch v1 16/29] s390x/sclp: propagate the ibc val(lowest and unblocked ibc), David Hildenbrand, 2016/08/02
[Qemu-devel] [Patch v1 17/29] s390x/sclp: propagate the mha via sclp, David Hildenbrand, 2016/08/02
[Qemu-devel] [Patch v1 15/29] s390x/sclp: indicate sclp features, David Hildenbrand, 2016/08/02
[Qemu-devel] [Patch v1 03/29] s390x/cpumodel: expose CPU class properties, David Hildenbrand, 2016/08/02
[Qemu-devel] [Patch v1 07/29] s390x/cpumodel: introduce CPU feature group definitions, David Hildenbrand, 2016/08/02
[Qemu-devel] [Patch v1 14/29] s390x/sclp: introduce sclp feature blocks, David Hildenbrand, 2016/08/02
[Qemu-devel] [Patch v1 12/29] s390x/cpumodel: check and apply the CPU model, David Hildenbrand, 2016/08/02
[Qemu-devel] [Patch v1 18/29] s390x/sclp: propagate hmfai, David Hildenbrand, 2016/08/02
[Qemu-devel] [Patch v1 24/29] qmp: add QMP interface "query-cpu-model-expansion", David Hildenbrand, 2016/08/02