qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] curl: Cast fd to int for DPRINTF


From: John Snow
Subject: Re: [Qemu-devel] [PATCH] curl: Cast fd to int for DPRINTF
Date: Mon, 1 Aug 2016 22:59:10 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0



On 08/01/2016 09:09 PM, Fam Zheng wrote:
On Mon, 08/01 12:41, John Snow wrote:
-    DPRINTF("CURL (AIO): Sock action %d on fd %d\n", action, fd);
+    DPRINTF("CURL (AIO): Sock action %d on fd %d\n", action, (int)fd);
     switch (action) {
         case CURL_POLL_IN:
             aio_set_fd_handler(s->aio_context, fd, false,


Is curl_socket_t always of type long long unsigned int? why not use %llu ?

Since it is a typedef, variation between platforms is imaginable. On Linux it
is 4 bytes, the error is only seen on Windows.

Fam


Ah, there we go. The B-O-D was justified. :)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]