[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 20/37] char: free MuxDriver when closing
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 20/37] char: free MuxDriver when closing |
Date: |
Mon, 1 Aug 2016 14:52:01 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 01/08/2016 14:50, Paolo Bonzini wrote:
>
>
> On 28/07/2016 16:37, address@hidden wrote:
>> From: Marc-André Lureau <address@hidden>
>>
>> Similarly to other chr_close callbacks, free char type specific data.
>>
>> Signed-off-by: Marc-André Lureau <address@hidden>
>> ---
>> qemu-char.c | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/qemu-char.c b/qemu-char.c
>> index 6ed6dd6..e276485 100644
>> --- a/qemu-char.c
>> +++ b/qemu-char.c
>> @@ -786,6 +786,14 @@ static GSource *mux_chr_add_watch(CharDriverState *s,
>> GIOCondition cond)
>> return d->drv->chr_add_watch(d->drv, cond);
>> }
>>
>> +static void mux_chr_close(struct CharDriverState *chr)
>> +{
>> + MuxDriver *d = chr->opaque;
>> +
>> + /* is more cleanup needed? */
>
> Perhaps qemu_chr_free(d->drv)?
Hmm, no, a qemu_chr_delete(mux) could conceivably delete d->drv too, but
not a free. So the patch is okay with the comment removed.
Paolo