[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [QEMU v2 1/9] virtio-balloon: Remove needless precompil
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [QEMU v2 1/9] virtio-balloon: Remove needless precompiled directive |
Date: |
Mon, 1 Aug 2016 11:42:03 +0100 |
User-agent: |
Mutt/1.6.2 (2016-07-01) |
* Liang Li (address@hidden) wrote:
> Since there in wrapper around madvise(), the virtio-balloon
> code is able to work without the precompiled directive, the
> directive can be removed.
>
> Signed-off-by: Liang Li <address@hidden>
> Suggested-by: Thomas Huth <address@hidden>
This one could be posted separately.
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> hw/virtio/virtio-balloon.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
> index 1a22e6d..62931b3 100644
> --- a/hw/virtio/virtio-balloon.c
> +++ b/hw/virtio/virtio-balloon.c
> @@ -34,13 +34,11 @@
>
> static void balloon_page(void *addr, int deflate)
> {
> -#if defined(__linux__)
> if (!qemu_balloon_is_inhibited() && (!kvm_enabled() ||
> kvm_has_sync_mmu())) {
> qemu_madvise(addr, BALLOON_PAGE_SIZE,
> deflate ? QEMU_MADV_WILLNEED : QEMU_MADV_DONTNEED);
> }
> -#endif
> }
>
> static const char *balloon_stat_names[] = {
> --
> 1.9.1
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- Re: [Qemu-devel] [QEMU v2 1/9] virtio-balloon: Remove needless precompiled directive,
Dr. David Alan Gilbert <=