Re: [Qemu-devel] [PATCH for 2.8 1/3] rules.mak: Don't extract libs from .mo-libs in link command

[Paolo Bonzini]

On 27/07/2016 08:26, Fam Zheng wrote:
> For module build, .mo objects are passed to LINK and consumed in
> process-archive-undefs. The reason behind that is documented in the
> comment above process-archive-undefs.
> 
> Similarly, extract-libs should be called with .mo filtered out too.
> Otherwise, the .mo-libs are added to the link command incorrectly,
> spoiling the purpose of modularization.
> 
> Currently we don't have any .mo-libs usage, but it will be used soon
> when we modularize more multi-source objects, like sdl and gtk.
> 
> Reported-by: Colin Lord <address@hidden>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
>  rules.mak | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rules.mak b/rules.mak
> index ed8e482..80705a7 100644
> --- a/rules.mak
> +++ b/rules.mak
> @@ -50,7 +50,7 @@ process-archive-undefs = $(filter-out %.a %.mo,$1) \
>                                $(call undefined-symbols,$(filter %.mo,$1)))) \
>                  $(filter %.a,$1)
>  
> -extract-libs = $(strip $(foreach o,$1,$($o-libs)))
> +extract-libs = $(strip $(foreach o,$(filter-out %.mo,$1),$($o-libs)))
>  expand-objs = $(strip $(sort $(filter %.o,$1)) \
>                    $(foreach o,$(filter %.mo,$1),$($o-objs)) \
>                    $(filter-out %.o %.mo,$1))
> 

Acked-by: Paolo Bonzini <address@hidden>

Paolo