[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] mptsas: Fix a migration compatible issue
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] mptsas: Fix a migration compatible issue |
Date: |
Mon, 1 Aug 2016 10:16:50 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 26/07/2016 11:03, Cao jin wrote:
> My previous commit 2e2aa316 removed internal flag msi_in_use, which
> exists in vmstate, use VMSTATE_UNUSED for migration compatibility.
>
> Reported-by: Amit Shah <address@hidden>
> Suggested-by: Amit Shah <address@hidden>
> Cc: Markus Armbruster <address@hidden>
> Cc: Marcel Apfelbaum <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Cc: Michael S. Tsirkin <address@hidden>
> Cc: Amit Shah <address@hidden>
> Signed-off-by: Cao jin <address@hidden>
> ---
> hw/scsi/mptsas.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/scsi/mptsas.c b/hw/scsi/mptsas.c
> index c1a0649..0ed24d1 100644
> --- a/hw/scsi/mptsas.c
> +++ b/hw/scsi/mptsas.c
> @@ -1370,7 +1370,7 @@ static const VMStateDescription vmstate_mptsas = {
> .post_load = mptsas_post_load,
> .fields = (VMStateField[]) {
> VMSTATE_PCI_DEVICE(dev, MPTSASState),
> -
> + VMSTATE_UNUSED(sizeof(bool)), /* Was msi_in_use */
This needs to be "1", not sizeof(bool), because vmstate_info_bool writes
a single byte. I'll fix this and queue the patch (removing Amit's
reviewed-by since it's effectively a different change).
Paolo
> VMSTATE_UINT32(state, MPTSASState),
> VMSTATE_UINT8(who_init, MPTSASState),
> VMSTATE_UINT8(doorbell_state, MPTSASState),
>
- Re: [Qemu-devel] [PATCH] mptsas: Fix a migration compatible issue,
Paolo Bonzini <=