qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v1 8/8] target-ppc: add extswsli[.] instruction


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v1 8/8] target-ppc: add extswsli[.] instruction
Date: Thu, 28 Jul 2016 18:34:13 +0530
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1

On 07/28/2016 12:19 PM, Nikunj A Dadhania wrote:
+    tcg_gen_ext32s_tl(dst, src);
+    if (sh != 0) {
+        tcg_gen_shli_tl(dst, dst, sh);
+    }

You need not test for sh != 0, since that will be done in tcg_gen_shli_tl. Otherwise,

Reviewed-by: Richard Henderson <address@hidden>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]