[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH v3] qemu-img: add skip option to dd
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH v3] qemu-img: add skip option to dd |
Date: |
Thu, 28 Jul 2016 10:12:04 +0100 |
On Wed, Jul 27, 2016 at 3:51 PM, Reda Sallahi <address@hidden> wrote:
> - qemu_opt_set_number(opts, BLOCK_OPT_SIZE, size, &error_abort);
> + if (dd.flags & C_SKIP && size < in.bsz * in.offset) {
> + error_report("%s: cannot skip to specified offset", in.filename);
> + qemu_opt_set_number(opts, BLOCK_OPT_SIZE, 0, &error_abort);
This looks odd. What is supposed to happen in this case? Do you have
a test case for it?