[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] util: remove the obsolete non-blocking conn
|
From: |
Daniel P. Berrange |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/3] util: remove the obsolete non-blocking connect |
|
Date: |
Thu, 28 Jul 2016 09:07:27 +0100 |
|
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Thu, Jul 28, 2016 at 03:39:29PM +0800, Cao jin wrote:
> The non-blocking connect mechanism is obsolete, and it doesn't work well
> in inet connection, because it will call getaddrinfo first and getaddrinfo
> will blocks on DNS lookups. Since commit e65c67e4 & d984464e, the non-blocking
> connect of migration goes through QIOChannel in a different manner(using a
> thread), and nobody use this old non-blocking connect anymore.
>
> Any newly written code which needs a non-blocking connect should use the
> QIOChannel code, so we can just rip out NonBlockingConnectHandler as a
> concept entirely.
>
> Suggested-by: Daniel P. Berrange <address@hidden>
> Cc: Daniel P. Berrange <address@hidden>
> Cc: Gerd Hoffmann <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Signed-off-by: Cao jin <address@hidden>
Reviewed-by: Daniel P. Berrange <address@hidden>
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|