qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [v9 00/19] QEMU:Xen stubdom vTPM for HVM virtual machin


From: Anthony PERARD
Subject: Re: [Qemu-devel] [v9 00/19] QEMU:Xen stubdom vTPM for HVM virtual machine(QEMU Part)
Date: Mon, 25 Jul 2016 15:09:41 +0100
User-agent: Mutt/1.6.2 (2016-07-01)

On Sun, Jul 10, 2016 at 02:47:31PM +0300, Emil Condrea wrote:
> Emil Condrea (19):
>   xen: Create a new file xen_pvdev.c
>   xen: Create a new file xen_frontend.c
>   xen: Move xenstore_update to xen_pvdev.c
>   xen: Move evtchn functions to xen_pvdev.c
>   xen: Prepare xendev qtail to be shared with frontends
>   xen: Rename xen_be_printf to xen_pv_printf
>   xen: Rename xen_be_unbind_evtchn
>   xen: Rename xen_be_send_notify
>   xen: Rename xen_be_evtchn_event
>   xen: Rename xen_be_find_xendev
>   xen: Rename xen_be_del_xendev
>   xen: Rename xen_be_frontend_changed

Patches from 1 to 12 looks fine but ./script/checkpatch.pl reveal some
coding style issue in the code that is moved. Could you fix those issues
in separate patches?  (Having separate patches for code movement and for
coding style fix makes it easier to review.)

I'll start reviewing the more complicated patches now.

Thanks,

-- 
Anthony PERARD



reply via email to

[Prev in Thread] Current Thread [Next in Thread]