[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/19] xen: Create a new file xen_pvdev.c
From: |
Anthony PERARD |
Subject: |
Re: [Qemu-devel] [PATCH 01/19] xen: Create a new file xen_pvdev.c |
Date: |
Mon, 25 Jul 2016 14:41:34 +0100 |
User-agent: |
Mutt/1.6.2 (2016-07-01) |
On Sun, Jul 10, 2016 at 02:47:32PM +0300, Emil Condrea wrote:
> The purpose of the new file is to store generic functions shared by frontend
> and backends such as xenstore operations, xendevs.
>
> Signed-off-by: Quan Xu <address@hidden>
> Signed-off-by: Emil Condrea <address@hidden>
> ---
> hw/xen/Makefile.objs | 2 +-
> hw/xen/xen_backend.c | 125 +-----------------------------------
> hw/xen/xen_pvdev.c | 149
> +++++++++++++++++++++++++++++++++++++++++++
> include/hw/xen/xen_backend.h | 63 +-----------------
> include/hw/xen/xen_pvdev.h | 71 +++++++++++++++++++++
> 5 files changed, 223 insertions(+), 187 deletions(-)
> create mode 100644 hw/xen/xen_pvdev.c
> create mode 100644 include/hw/xen/xen_pvdev.h
>
> diff --git a/include/hw/xen/xen_pvdev.h b/include/hw/xen/xen_pvdev.h
> new file mode 100644
> index 0000000..f60bfae
> --- /dev/null
> +++ b/include/hw/xen/xen_pvdev.h
> @@ -0,0 +1,71 @@
> +#ifndef QEMU_HW_XEN_PVDEV_H
> +#define QEMU_HW_XEN_PVDEV_H 1
No need for the 1. Just "#define X" is enough.
> +
> +#include "hw/xen/xen_common.h"
> +#include <inttypes.h>
I don't think this include is needed.
--
Anthony PERARD
- [Qemu-devel] [v9 00/19] QEMU:Xen stubdom vTPM for HVM virtual machine(QEMU Part), Emil Condrea, 2016/07/10
- [Qemu-devel] [PATCH 01/19] xen: Create a new file xen_pvdev.c, Emil Condrea, 2016/07/10
- Re: [Qemu-devel] [PATCH 01/19] xen: Create a new file xen_pvdev.c,
Anthony PERARD <=
- [Qemu-devel] [PATCH 02/19] xen: Create a new file xen_frontend.c, Emil Condrea, 2016/07/10
- [Qemu-devel] [PATCH 03/19] xen: Move xenstore_update to xen_pvdev.c, Emil Condrea, 2016/07/10
- [Qemu-devel] [PATCH 04/19] xen: Move evtchn functions to xen_pvdev.c, Emil Condrea, 2016/07/10
- [Qemu-devel] [PATCH 05/19] xen: Prepare xendev qtail to be shared with frontends, Emil Condrea, 2016/07/10
- [Qemu-devel] [PATCH 08/19] xen: Rename xen_be_send_notify, Emil Condrea, 2016/07/10