Re: [Qemu-devel] [PULL v3 00/55] pc, pci, virtio: new features, cleanups, fixes

[Fam Zheng]

On Thu, 07/21 11:45, Peter Maydell wrote:
> On 21 July 2016 at 11:36, Peter Xu <address@hidden> wrote:
> > On Thu, Jul 21, 2016 at 10:20:38AM +0100, Peter Maydell wrote:
> >> Fails to build:
> >>
> >> /home/petmay01/linaro/qemu-for-merges/hw/i386/intel_iommu.c: In
> >> function ‘vtd_remap_irq_get’:
> >> /home/petmay01/linaro/qemu-for-merges/hw/i386/intel_iommu.c:2092:5:
> >> error: missing braces around initializer [-Werror=missing-braces]
> >>      VTD_IRTE irte = { 0 };
> >>      ^
> >> /home/petmay01/linaro/qemu-for-merges/hw/i386/intel_iommu.c:2092:5:
> >> error: (near initialization for ‘irte.<anonymous>’)
> >> [-Werror=missing-braces]
> 
> > Is this a compiler specific issue? Since this can pass compile test on
> > my machine (both local build, or make docker-test). Do you have any
> > suggestion on how we can avoid this kind of errors in the future?
> 
> It failed on several of my test builds, not just one, but these
> things are tricky to avoid if they don't happen on all compilers.
> In this case I think it is a compiler bug:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53119
> so you'll only see it with an older compiler.

Could you name the distro and gcc version? If it's worth to keep the buggy
compiler happy, it probably can be added as a docker test. :)

Fam