Re: [Qemu-devel] [PATCH v2 03/12] monitor: register gen:false commands manually

[Eric Blake]

On 07/21/2016 08:00 AM, address@hidden wrote:
> From: Marc-André Lureau <address@hidden>
> 
> Since a few commands are using 'gen': false, they are not registered
> automatically by the generator. Register manually instead.
> 
> This is in preparation for removal of qapi 'middle' mode generation.
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
>  monitor.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 

> +static void qmp_init_marshal(void)
> +{
> +    qmp_register_command("query-qmp-schema", qmp_query_qmp_schema,
> +                         QCO_NO_OPTIONS);
> +    qmp_register_command("device_add", qmp_device_add,
> +                         QCO_NO_OPTIONS);
> +    qmp_register_command("netdev_add", qmp_netdev_add,
> +                         QCO_NO_OPTIONS);

Of course, if my netdev_add patch goes in first (currently on Markus'
qapi-not-next branch, because we decided it was too risky for 2.7 hard
freeze), then this last line is not needed.

R-b still stands.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature