[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/2] util/qemu-sockets: shoot inet_nonblocking_conne
From: |
Cao jin |
Subject: |
[Qemu-devel] [PATCH 1/2] util/qemu-sockets: shoot inet_nonblocking_connect() |
Date: |
Thu, 21 Jul 2016 18:33:32 +0800 |
It is never used, and now all connect is nonblocking via
inet_connect_addr().
Cc: Daniel P. Berrange <address@hidden>
Cc: Gerd Hoffmann <address@hidden>
Cc: Paolo Bonzini <address@hidden>
Signed-off-by: Cao jin <address@hidden>
---
include/qemu/sockets.h | 3 ---
util/qemu-sockets.c | 30 ------------------------------
2 files changed, 33 deletions(-)
diff --git a/include/qemu/sockets.h b/include/qemu/sockets.h
index 5fe01fb..2cbe643 100644
--- a/include/qemu/sockets.h
+++ b/include/qemu/sockets.h
@@ -36,9 +36,6 @@ InetSocketAddress *inet_parse(const char *str, Error **errp);
int inet_listen(const char *str, char *ostr, int olen,
int socktype, int port_offset, Error **errp);
int inet_connect(const char *str, Error **errp);
-int inet_nonblocking_connect(const char *str,
- NonBlockingConnectHandler *callback,
- void *opaque, Error **errp);
NetworkAddressFamily inet_netfamily(int family);
diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
index fb83d48..88b822a 100644
--- a/util/qemu-sockets.c
+++ b/util/qemu-sockets.c
@@ -674,36 +674,6 @@ int inet_connect(const char *str, Error **errp)
return sock;
}
-/**
- * Create a non-blocking socket and connect it to an address.
- * Calls the callback function with fd in case of success or -1 in case of
- * error.
- *
- * @str: address string
- * @callback: callback function that is called when connect completes,
- * cannot be NULL.
- * @opaque: opaque for callback function
- * @errp: set in case of an error
- *
- * Returns: -1 on immediate error, file descriptor on success.
- **/
-int inet_nonblocking_connect(const char *str,
- NonBlockingConnectHandler *callback,
- void *opaque, Error **errp)
-{
- int sock = -1;
- InetSocketAddress *addr;
-
- g_assert(callback != NULL);
-
- addr = inet_parse(str, errp);
- if (addr != NULL) {
- sock = inet_connect_saddr(addr, errp, callback, opaque);
- qapi_free_InetSocketAddress(addr);
- }
- return sock;
-}
-
#ifndef _WIN32
static int unix_listen_saddr(UnixSocketAddress *saddr,
--
2.1.0
- [Qemu-devel] [PATCH 0/2] qemu-sockets: remove useless functions, Cao jin, 2016/07/21
- [Qemu-devel] [PATCH 2/2] util/qemu-sockets: shoot unix_nonblocking_connect(), Cao jin, 2016/07/21
- Re: [Qemu-devel] [PATCH 2/2] util/qemu-sockets: shoot unix_nonblocking_connect(), Eric Blake, 2016/07/21
- Re: [Qemu-devel] [PATCH 2/2] util/qemu-sockets: shoot unix_nonblocking_connect(), Daniel P. Berrange, 2016/07/21
- Re: [Qemu-devel] [PATCH 2/2] util/qemu-sockets: shoot unix_nonblocking_connect(), Cao jin, 2016/07/22
- Re: [Qemu-devel] [PATCH 2/2] util/qemu-sockets: shoot unix_nonblocking_connect(), Daniel P. Berrange, 2016/07/22
- Re: [Qemu-devel] [PATCH 2/2] util/qemu-sockets: shoot unix_nonblocking_connect(), Cao jin, 2016/07/22
- Re: [Qemu-devel] [PATCH 2/2] util/qemu-sockets: shoot unix_nonblocking_connect(), Daniel P. Berrange, 2016/07/22
- Re: [Qemu-devel] [PATCH 2/2] util/qemu-sockets: shoot unix_nonblocking_connect(), Cao jin, 2016/07/22
[Qemu-devel] [PATCH 1/2] util/qemu-sockets: shoot inet_nonblocking_connect(),
Cao jin <=
Re: [Qemu-devel] [PATCH 0/2] qemu-sockets: remove useless functions, Cao jin, 2016/07/21
Re: [Qemu-devel] [PATCH 0/2] qemu-sockets: remove useless functions, Paolo Bonzini, 2016/07/21