[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] checkpatch: add check for bzero
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH] checkpatch: add check for bzero |
Date: |
Thu, 21 Jul 2016 18:13:27 +0800 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Thu, Jul 21, 2016 at 11:03:20AM +0200, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <address@hidden>
Thanks, Paolo.
Tested-By: Peter Xu <address@hidden>
> ---
> scripts/checkpatch.pl | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index afa7f79..b7cb4ab 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2544,7 +2544,7 @@ sub process {
> }
> }
>
> -# check for non-portable ffs() calls that have portable alternatives in QEMU
> +# check for non-portable libc calls that have portable alternatives in QEMU
> if ($line =~ /\bffs\(/) {
> ERROR("use ctz32() instead of ffs()\n" . $herecurr);
> }
> @@ -2554,6 +2554,9 @@ sub process {
> if ($line =~ /\bffsll\(/) {
> ERROR("use ctz64() instead of ffsll()\n" . $herecurr);
> }
> + if ($line =~ /\bbzero\(/) {
> + ERROR("use memset() instead of bzero()\n" . $herecurr);
> + }
> }
>
> # If we have no input at all, then there is nothing to report on
> --
> 2.7.4
>
>