[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v3 36/55] virtio: Add typedef for handle_output
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL v3 36/55] virtio: Add typedef for handle_output |
Date: |
Wed, 20 Jul 2016 20:47:49 +0300 |
From: Fam Zheng <address@hidden>
The function pointer signature has been repeated a few times, using a
typedef may make coding easier.
Signed-off-by: Fam Zheng <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Acked-by: Paolo Bonzini <address@hidden>
---
include/hw/virtio/virtio.h | 5 +++--
hw/virtio/virtio.c | 9 ++++-----
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
index 8a681f5..3670829 100644
--- a/include/hw/virtio/virtio.h
+++ b/include/hw/virtio/virtio.h
@@ -138,9 +138,10 @@ void virtio_cleanup(VirtIODevice *vdev);
/* Set the child bus name. */
void virtio_device_set_child_bus_name(VirtIODevice *vdev, char *bus_name);
+typedef void (*VirtIOHandleOutput)(VirtIODevice *, VirtQueue *);
+
VirtQueue *virtio_add_queue(VirtIODevice *vdev, int queue_size,
- void (*handle_output)(VirtIODevice *,
- VirtQueue *));
+ VirtIOHandleOutput handle_output);
void virtio_del_queue(VirtIODevice *vdev, int n);
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 18153d5..2cc68d24 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -95,8 +95,8 @@ struct VirtQueue
int inuse;
uint16_t vector;
- void (*handle_output)(VirtIODevice *vdev, VirtQueue *vq);
- void (*handle_aio_output)(VirtIODevice *vdev, VirtQueue *vq);
+ VirtIOHandleOutput handle_output;
+ VirtIOHandleOutput handle_aio_output;
VirtIODevice *vdev;
EventNotifier guest_notifier;
EventNotifier host_notifier;
@@ -1131,7 +1131,7 @@ void virtio_queue_set_vector(VirtIODevice *vdev, int n,
uint16_t vector)
}
VirtQueue *virtio_add_queue(VirtIODevice *vdev, int queue_size,
- void (*handle_output)(VirtIODevice *, VirtQueue *))
+ VirtIOHandleOutput handle_output)
{
int i;
@@ -1804,8 +1804,7 @@ static void
virtio_queue_host_notifier_aio_read(EventNotifier *n)
}
void virtio_queue_aio_set_host_notifier_handler(VirtQueue *vq, AioContext *ctx,
- void
(*handle_output)(VirtIODevice *,
-
VirtQueue *))
+ VirtIOHandleOutput
handle_output)
{
if (handle_output) {
vq->handle_aio_output = handle_output;
--
MST
- [Qemu-devel] [PULL v3 26/55] ioapic: register IOMMU IEC notifier for ioapic, (continued)
- [Qemu-devel] [PULL v3 26/55] ioapic: register IOMMU IEC notifier for ioapic, Michael S. Tsirkin, 2016/07/20
- [Qemu-devel] [PULL v3 27/55] intel_iommu: Add support for Extended Interrupt Mode, Michael S. Tsirkin, 2016/07/20
- [Qemu-devel] [PULL v3 28/55] intel_iommu: add SID validation for IR, Michael S. Tsirkin, 2016/07/20
- [Qemu-devel] [PULL v3 29/55] kvm-irqchip: simplify kvm_irqchip_add_msi_route, Michael S. Tsirkin, 2016/07/20
- [Qemu-devel] [PULL v3 30/55] kvm-irqchip: i386: add hook for add/remove virq, Michael S. Tsirkin, 2016/07/20
- [Qemu-devel] [PULL v3 31/55] kvm-irqchip: x86: add msi route notify fn, Michael S. Tsirkin, 2016/07/20
- [Qemu-devel] [PULL v3 32/55] kvm-irqchip: do explicit commit when update irq, Michael S. Tsirkin, 2016/07/20
- [Qemu-devel] [PULL v3 33/55] intel_iommu: support all masks in interrupt entry cache invalidation, Michael S. Tsirkin, 2016/07/20
- [Qemu-devel] [PULL v3 34/55] kvm-all: add trace events for kvm irqchip ops, Michael S. Tsirkin, 2016/07/20
- [Qemu-devel] [PULL v3 35/55] intel_iommu: disallow kernel-irqchip=on with IR, Michael S. Tsirkin, 2016/07/20
- [Qemu-devel] [PULL v3 36/55] virtio: Add typedef for handle_output,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL v3 37/55] virtio: Introduce virtio_add_queue_aio, Michael S. Tsirkin, 2016/07/20
- [Qemu-devel] [PULL v3 39/55] virtio-scsi: Call virtio_add_queue_aio, Michael S. Tsirkin, 2016/07/20
- [Qemu-devel] [PULL v3 38/55] virtio-blk: Call virtio_add_queue_aio, Michael S. Tsirkin, 2016/07/20
- [Qemu-devel] [PULL v3 41/55] virtio-scsi: Replace HandleOutput typedef, Michael S. Tsirkin, 2016/07/20
- [Qemu-devel] [PULL v3 40/55] Revert "mirror: Workaround for unexpected iohandler events during completion", Michael S. Tsirkin, 2016/07/20
- [Qemu-devel] [PULL v3 42/55] virtio-net: Remove old migration version support, Michael S. Tsirkin, 2016/07/20
- [Qemu-devel] [PULL v3 43/55] virtio-serial: Remove old migration version support, Michael S. Tsirkin, 2016/07/20
- [Qemu-devel] [PULL v3 44/55] virtio: Migration helper function and macro, Michael S. Tsirkin, 2016/07/20
- [Qemu-devel] [PULL v3 45/55] virtio-scsi: Wrap in vmstate, Michael S. Tsirkin, 2016/07/20
- [Qemu-devel] [PULL v3 47/55] virtio-rng: Wrap in vmstate, Michael S. Tsirkin, 2016/07/20