Re: [Qemu-devel] [PATCH 25/37] ahci: free irqs array

[John Snow]

On 07/19/2016 04:54 AM, address@hidden wrote:
> From: Marc-André Lureau <address@hidden>
> 
> Each irq is referenced by the IDEBus in ide_init2(), thus we can free
> the no longer used array.
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  hw/ide/ahci.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
> index bcb9ff9..6defeed 100644
> --- a/hw/ide/ahci.c
> +++ b/hw/ide/ahci.c
> @@ -1478,6 +1478,7 @@ void ahci_realize(AHCIState *s, DeviceState *qdev, 
> AddressSpace *as, int ports)
>          ad->port.dma->ops = &ahci_dma_ops;
>          ide_register_restart_cb(&ad->port);
>      }
> +    g_free(irqs);
>  }
>  
>  void ahci_uninit(AHCIState *s)
> 

Oh, we pass these by-value, so yes.

Reviewed-by: John Snow <address@hidden>

And if this entire series gets picked up, have an ACK to mean "I don't
care who stages this:"

Acked-by: John Snow <address@hidden>