[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 15/16] target-i386: add x86_cpu_unrealizefn()
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v4 15/16] target-i386: add x86_cpu_unrealizefn() |
Date: |
Tue, 19 Jul 2016 14:05:44 -0300 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Thu, Jul 14, 2016 at 06:54:44PM +0200, Igor Mammedov wrote:
> first remove VCPU from exec loop and only then remove lapic.
>
> Signed-off-by: Chen Fan <address@hidden>
> Signed-off-by: Gu Zheng <address@hidden>
> Signed-off-by: Zhu Guihua <address@hidden>
> Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
> ---
> target-i386/cpu.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 73ed447..f904671 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -3117,6 +3117,21 @@ out:
> }
> }
>
> +static void x86_cpu_unrealizefn(DeviceState *dev, Error **errp)
> +{
> + X86CPU *cpu = X86_CPU(dev);
> +
> +#ifndef CONFIG_USER_ONLY
> + cpu_remove_sync(CPU(dev));
> + qemu_unregister_reset(x86_cpu_machine_reset_cb, dev);
> +#endif
> +
> + if (cpu->apic_state) {
> + object_unparent(OBJECT(cpu->apic_state));
> + cpu->apic_state = NULL;
> + }
> +}
> +
> typedef struct BitProperty {
> uint32_t *ptr;
> uint32_t mask;
> @@ -3363,6 +3378,7 @@ static void x86_cpu_common_class_init(ObjectClass *oc,
> void *data)
>
> xcc->parent_realize = dc->realize;
> dc->realize = x86_cpu_realizefn;
> + dc->unrealize = x86_cpu_unrealizefn;
> dc->props = x86_cpu_properties;
>
> xcc->parent_reset = cc->reset;
> --
> 2.7.4
>
>
--
Eduardo
- [Qemu-devel] [PATCH v4 09/16] apic: drop APICCommonState.idx and use APIC ID as index in local_apics[], (continued)
- [Qemu-devel] [PATCH v4 09/16] apic: drop APICCommonState.idx and use APIC ID as index in local_apics[], Igor Mammedov, 2016/07/14
- [Qemu-devel] [PATCH v4 08/16] apic: move MAX_APICS check to 'apic' class, Igor Mammedov, 2016/07/14
- [Qemu-devel] [PATCH v4 11/16] (kvm)apic: add unrealize callbacks, Igor Mammedov, 2016/07/14
- [Qemu-devel] [PATCH v4 10/16] apic: kvm-apic: fix crash due to access to freed memory region, Igor Mammedov, 2016/07/14
- [Qemu-devel] [PATCH v4 13/16] target-i386: cpu: do not ignore error and fix apic parent, Igor Mammedov, 2016/07/14
- [Qemu-devel] [PATCH v4 12/16] apic: use apic_id as apic's migration instance_id, Igor Mammedov, 2016/07/14
- [Qemu-devel] [PATCH v4 14/16] target-i386: fix apic object leak when CPU is deleted, Igor Mammedov, 2016/07/14
- [Qemu-devel] [PATCH v4 15/16] target-i386: add x86_cpu_unrealizefn(), Igor Mammedov, 2016/07/14
- Re: [Qemu-devel] [PATCH v4 15/16] target-i386: add x86_cpu_unrealizefn(),
Eduardo Habkost <=
- [Qemu-devel] [PATCH v4 16/16] pc: make device_del CPU work for x86 CPUs, Igor Mammedov, 2016/07/14
- Re: [Qemu-devel] [PATCH v4 00/16] pc: add CPU hot-add/hot-remove with device_add/device_del, Michael S. Tsirkin, 2016/07/18