qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v8 0/4] block: ignore flush requests when storag


From: John Snow
Subject: Re: [Qemu-devel] [PATCH v8 0/4] block: ignore flush requests when storage is clean
Date: Mon, 18 Jul 2016 18:22:04 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1


On 07/18/2016 03:39 PM, Denis V. Lunev wrote:
> Changes from v7:
> - fixed 026 test in cached mode (different output)
> 
> Changes from v6:
> - squashed patches 5-6 into patch 4 to avoid test faults on git bissect
> - changed sector number from 0 to 1 in patch 3
> 
> Changes from v5:
> - Removed failed flush traces in block tests 026 071 089
> - Changed BLOCK_JOB_READY event order in block tests 141 144
> 
> Changes from v4:
> - Moved to write generation scheme instead of dirty flag
> - Added retry setup to IDE PIO and FLUSH requests
> 
> Changes from v3:
> - Fixed a typo in commit message
> - Rebased on Kevin'n origin/block
> 
> Changes from v2:
> - Better comments
> - Rebased on latest master
> 
> Changes from v1:
> - Flush requests that should be skipped will now wait for completion
>   of any previous requests already in flight
> - Fixed IDE and AHCI tests to dirty media for new flush behaviour
> - Fixed a problem in IDE CMD_FLUSH_CACHE failure handling
> 
> Signed-off-by: Evgeny Yakovlev <address@hidden>
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Kevin Wolf <address@hidden>
> CC: Max Reitz <address@hidden>
> CC: Stefan Hajnoczi <address@hidden>
> CC: Fam Zheng <address@hidden>
> CC: John Snow <address@hidden>
> 
> Evgeny Yakovlev (4):
>   ide: refactor retry_unit set and clear into separate function
>   ide: set retry_unit for PIO and FLUSH requests
>   tests: in IDE and AHCI tests perform DMA write before flushing
>   block: ignore flush requests when storage is clean
> 
>  block.c                            |  3 +++
>  block/io.c                         | 21 ++++++++++++++++
>  hw/ide/core.c                      | 24 +++++++++++++-----
>  include/block/block_int.h          |  5 ++++
>  tests/ahci-test.c                  | 34 ++++++++++++++++++++++++--
>  tests/ide-test.c                   | 43 ++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/026.out         | 50 
> --------------------------------------
>  tests/qemu-iotests/026.out.nocache | 50 
> --------------------------------------
>  tests/qemu-iotests/071.out         |  8 ------
>  tests/qemu-iotests/089.out         |  2 --
>  tests/qemu-iotests/141.out         |  4 +--
>  tests/qemu-iotests/144.out         |  2 +-
>  12 files changed, 125 insertions(+), 121 deletions(-)
> 

Thanks so much for the quick respin, sorry for all the hassle!

Thanks Denis & Evgeny!

Thanks, applied to my IDE tree:

https://github.com/jnsnow/qemu/commits/ide
https://github.com/jnsnow/qemu.git

--js



reply via email to

[Prev in Thread] Current Thread [Next in Thread]