Re: [Qemu-devel] [PATCH] net: fix incorrect access to pointer

[Jason Wang]

On 2016年07月15日 16:43, Paolo Bonzini wrote:
> This is not dereferencing the pointer, and instead checking only
> the value of the pointer.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>   net/eth.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/eth.c b/net/eth.c
> index 0be59c2..df81efb 100644
> --- a/net/eth.c
> +++ b/net/eth.c
> @@ -211,7 +211,7 @@ void eth_get_protocols(const struct iovec *iov, int iovcnt,
>                                        *l4hdr_off, sizeof(l4hdr_info->hdr.tcp),
>                                        &l4hdr_info->hdr.tcp);
>   
> -            if (istcp) {
> +            if (*istcp) {
>                   *l5hdr_off = *l4hdr_off +
>                       TCP_HEADER_DATA_OFFSET(&l4hdr_info->hdr.tcp);
>   

Applied to -net. Thanks