[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v11 14/28] intel_iommu: Add support for PCI MSI
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v11 14/28] intel_iommu: Add support for PCI MSI remap |
Date: |
Thu, 14 Jul 2016 13:23:05 +0800 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Wed, Jul 13, 2016 at 04:17:01PM +0300, David Kiarie wrote:
[...]
> > +static MemTxResult vtd_mem_ir_read(void *opaque, hwaddr addr,
> > + uint64_t *data, unsigned size,
> > + MemTxAttrs attrs)
> > +{
> > + addr += VTD_INTERRUPT_ADDR_FIRST;
> > +
> > + VTD_DPRINTF(IR, "read mem_ir addr 0x%"PRIx64 " size %u",
> > + addr, size);
> > +
> > + if (dma_memory_read(&address_space_memory, addr, &data, size)) {
> > + VTD_DPRINTF(GENERAL, "error: fail to access 0x%"PRIx64, addr);
> > + return MEMTX_ERROR;
> > + }
> > +
> > + return MEMTX_OK;
> > +}
>
> I'm looking at this and wondering whether dma_memory_read expected a
> double pointer as the third argument. (??)
Right. It's dangerous and should never be touched. Maybe I should keep
this an empty function, just like what APIC is doing. Read at
address_space_memory is odd here in all cases...
Thanks, David.
-- peterx
- [Qemu-devel] [PATCH v11 06/28] acpi: enable INTR for DMAR report structure, (continued)
- [Qemu-devel] [PATCH v11 06/28] acpi: enable INTR for DMAR report structure, Peter Xu, 2016/07/05
- [Qemu-devel] [PATCH v11 07/28] intel_iommu: allow queued invalidation for IR, Peter Xu, 2016/07/05
- [Qemu-devel] [PATCH v11 08/28] intel_iommu: set IR bit for ECAP register, Peter Xu, 2016/07/05
- [Qemu-devel] [PATCH v11 09/28] acpi: add DMAR scope definition for root IOAPIC, Peter Xu, 2016/07/05
- [Qemu-devel] [PATCH v11 10/28] intel_iommu: define interrupt remap table addr register, Peter Xu, 2016/07/05
- [Qemu-devel] [PATCH v11 11/28] intel_iommu: handle interrupt remap enable, Peter Xu, 2016/07/05
- [Qemu-devel] [PATCH v11 12/28] intel_iommu: define several structs for IOMMU IR, Peter Xu, 2016/07/05
- [Qemu-devel] [PATCH v11 13/28] intel_iommu: add IR translation faults defines, Peter Xu, 2016/07/05
- [Qemu-devel] [PATCH v11 14/28] intel_iommu: Add support for PCI MSI remap, Peter Xu, 2016/07/05
- [Qemu-devel] [PATCH v11 15/28] q35: ioapic: add support for emulated IOAPIC IR, Peter Xu, 2016/07/05
- [Qemu-devel] [PATCH v11 16/28] ioapic: introduce ioapic_entry_parse() helper, Peter Xu, 2016/07/05
- [Qemu-devel] [PATCH v11 17/28] intel_iommu: add support for split irqchip, Peter Xu, 2016/07/05
- [Qemu-devel] [PATCH v11 18/28] x86-iommu: introduce IEC notifiers, Peter Xu, 2016/07/05
- [Qemu-devel] [PATCH v11 19/28] ioapic: register IOMMU IEC notifier for ioapic, Peter Xu, 2016/07/05
- [Qemu-devel] [PATCH v11 20/28] intel_iommu: Add support for Extended Interrupt Mode, Peter Xu, 2016/07/05
- [Qemu-devel] [PATCH v11 21/28] intel_iommu: add SID validation for IR, Peter Xu, 2016/07/05
- [Qemu-devel] [PATCH v11 22/28] kvm-irqchip: simplify kvm_irqchip_add_msi_route, Peter Xu, 2016/07/05
- [Qemu-devel] [PATCH v11 23/28] kvm-irqchip: i386: add hook for add/remove virq, Peter Xu, 2016/07/05
- [Qemu-devel] [PATCH v11 24/28] kvm-irqchip: x86: add msi route notify fn, Peter Xu, 2016/07/05