[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] machine: add comment to abort path in machine_s
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH] machine: add comment to abort path in machine_set_kernel_irqchip |
|
Date: |
Wed, 13 Jul 2016 17:03:30 -0300 |
|
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Wed, Jul 13, 2016 at 08:11:45PM +0200, Greg Kurz wrote:
> We're not supposed to abort when the user passes a bogus value.
> Since the ckecing is done in visit_type_OnOffSplit(), the call to
> abort() is legitimate. Let's add a comment to make it explicit.
>
> Signed-off-by: Greg Kurz <address@hidden>
Applied to machine-next, thanks. Although I believe the property
should be changed to use object_property_add_enum() instead.
--
Eduardo