[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 4/8] linux-user: Fix error handling in flatload.c ta
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH 4/8] linux-user: Fix error handling in flatload.c target_pread() |
Date: |
Tue, 12 Jul 2016 13:02:15 +0100 |
The flatload.c target_pread() function is supposed to return
0 on success or negative host errnos; however it wasn't
checking lock_user() for failure or returning the errno from
the pread() call. Fix these problems (the first of which is
noted by Coverity).
Signed-off-by: Peter Maydell <address@hidden>
---
linux-user/flatload.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/linux-user/flatload.c b/linux-user/flatload.c
index 48ad1c5..99492d3 100644
--- a/linux-user/flatload.c
+++ b/linux-user/flatload.c
@@ -95,7 +95,13 @@ static int target_pread(int fd, abi_ulong ptr, abi_ulong len,
int ret;
buf = lock_user(VERIFY_WRITE, ptr, len, 0);
+ if (!buf) {
+ return -EFAULT;
+ }
ret = pread(fd, buf, len, offset);
+ if (ret < 0) {
+ ret = -errno;
+ }
unlock_user(buf, ptr, len);
return ret;
}
--
1.9.1
- [Qemu-devel] [PATCH 0/8] linux-user: fix various coverity nits, Peter Maydell, 2016/07/12
- [Qemu-devel] [PATCH 1/8] linux-user: Pass missing MAP_ANONYMOUS to target_mmap() call, Peter Maydell, 2016/07/12
- [Qemu-devel] [PATCH 2/8] linux-user: Check lock_user() return value for NULL, Peter Maydell, 2016/07/12
- [Qemu-devel] [PATCH 5/8] linux-user: Don't write off end of new_utsname buffer, Peter Maydell, 2016/07/12
- [Qemu-devel] [PATCH 7/8] linux-user: Use glib malloc functions in load_symbols(), Peter Maydell, 2016/07/12
- [Qemu-devel] [PATCH 6/8] linux-user: Check dump_write() return in elf_core_dump(), Peter Maydell, 2016/07/12
- [Qemu-devel] [PATCH 4/8] linux-user: Fix error handling in flatload.c target_pread(),
Peter Maydell <=
- [Qemu-devel] [PATCH 3/8] linux-user: Fix incorrect use of host errno in do_ioctl_dm(), Peter Maydell, 2016/07/12
- [Qemu-devel] [PATCH 8/8] linux-user: Fix memchr() argument in open_self_cmdline(), Peter Maydell, 2016/07/12
- Re: [Qemu-devel] [PATCH 0/8] linux-user: fix various coverity nits, Paolo Bonzini, 2016/07/12