[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 08/19] pc: implement query-hotpluggable-cpus
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v3 08/19] pc: implement query-hotpluggable-cpus callback |
Date: |
Mon, 11 Jul 2016 23:54:42 -0300 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Wed, Jul 06, 2016 at 08:20:44AM +0200, Igor Mammedov wrote:
> it returns a list of present/possible to hotplug CPU
> objects with a list of properties to use with
> device_add.
>
> in PC case returned list would looks like:
> -> { "execute": "query-hotpluggable-cpus" }
> <- {"return": [
> {
> "type": "qemu64-x86_64-cpu", "vcpus-count": 1,
> "props": {"core-id": 0, "socket-id": 1, "thread-id": 0}
> },
> {
> "qom-path": "/machine/unattached/device[0]",
> "type": "qemu64-x86_64-cpu", "vcpus-count": 1,
> "props": {"core-id": 0, "socket-id": 0, "thread-id": 0}
> }
> ]}
>
> Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
But shouldn't this be at the end of the series, or at least after
the code that makes device_add work with X86CPU?
--
Eduardo
- Re: [Qemu-devel] [PATCH v3 04/19] pc: cpu: consolidate apic-id validity checks in pc_cpu_pre_plug(), (continued)
[Qemu-devel] [PATCH v3 05/19] target-i386: cpu: replace custom apic-id setter/getter with static property, Igor Mammedov, 2016/07/06
[Qemu-devel] [PATCH v3 06/19] target-i386: add socket/core/thread properties to X86CPU, Igor Mammedov, 2016/07/06
[Qemu-devel] [PATCH v3 07/19] pc: set APIC ID based on socket/core/thread ids if it's not been set yet, Igor Mammedov, 2016/07/06
[Qemu-devel] [PATCH v3 08/19] pc: implement query-hotpluggable-cpus callback, Igor Mammedov, 2016/07/06
[Qemu-devel] [PATCH v3 09/19] pc: delay setting number of boot CPUs to machine_done time, Igor Mammedov, 2016/07/06
Re: [Qemu-devel] [PATCH v3 09/19] pc: delay setting number of boot CPUs to machine_done time, Eduardo Habkost, 2016/07/12
Re: [Qemu-devel] [PATCH v3 09/19] pc: delay setting number of boot CPUs to machine_done time, Igor Mammedov, 2016/07/13