[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/6] Reduce lock contention on TCG hot-path
From: |
Emilio G. Cota |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/6] Reduce lock contention on TCG hot-path |
Date: |
Thu, 7 Jul 2016 12:04:39 -0400 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, Jul 05, 2016 at 17:18:10 +0100, Alex Bennée wrote:
> Well this is the first re-spin of the series posted last week. I've
> added a bunch of additional patches to be more aggressive with
> avoiding bouncing locks but to be honest the numbers don't seem to
> make it worth it.
How many threads are you using? With just a few threads I wouldn't
expect a measurable difference.
> I think the first 3 patches are ready to take if the TCG maintainers
> want to:
>
> tcg: Ensure safe tb_jmp_cache lookup out of 'tb_lock'
> tcg: set up tb->page_addr before insertion
> tcg: cpu-exec: remove tb_lock from the hot-path
I think it would be simpler to use tb_lock_recursive and
tb_lock_reset, as pointed out in v1 of this series.
Thanks,
Emilio
- Re: [Qemu-devel] [PATCH 3/3] tcg: Avoid bouncing tb_lock between tb_gen_code() and tb_add_jump(), (continued)
- Re: [Qemu-devel] [PATCH 3/3] tcg: Avoid bouncing tb_lock between tb_gen_code() and tb_add_jump(), Paolo Bonzini, 2016/07/08
- Re: [Qemu-devel] [PATCH 3/3] tcg: Avoid bouncing tb_lock between tb_gen_code() and tb_add_jump(), Sergey Fedorov, 2016/07/08
- Re: [Qemu-devel] [PATCH 3/3] tcg: Avoid bouncing tb_lock between tb_gen_code() and tb_add_jump(), Paolo Bonzini, 2016/07/08
- Re: [Qemu-devel] [PATCH 3/3] tcg: Avoid bouncing tb_lock between tb_gen_code() and tb_add_jump(), Sergey Fedorov, 2016/07/08
- Re: [Qemu-devel] [PATCH 3/3] tcg: Avoid bouncing tb_lock between tb_gen_code() and tb_add_jump(), Paolo Bonzini, 2016/07/08
- Re: [Qemu-devel] [PATCH 3/3] tcg: Avoid bouncing tb_lock between tb_gen_code() and tb_add_jump(), Sergey Fedorov, 2016/07/08
- Re: [Qemu-devel] [PATCH 3/3] tcg: Avoid bouncing tb_lock between tb_gen_code() and tb_add_jump(), Paolo Bonzini, 2016/07/08
- Re: [Qemu-devel] [PATCH 3/3] tcg: Avoid bouncing tb_lock between tb_gen_code() and tb_add_jump(), Sergey Fedorov, 2016/07/11
- Re: [Qemu-devel] [PATCH 3/3] tcg: Avoid bouncing tb_lock between tb_gen_code() and tb_add_jump(), Paolo Bonzini, 2016/07/11
- Re: [Qemu-devel] [PATCH 3/3] tcg: Avoid bouncing tb_lock between tb_gen_code() and tb_add_jump(), Sergey Fedorov, 2016/07/11
Re: [Qemu-devel] [PATCH v2 0/6] Reduce lock contention on TCG hot-path,
Emilio G. Cota <=