[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 16/28] Revert "vhost-net: do not crash if backend
From: |
marcandre . lureau |
Subject: |
[Qemu-devel] [PATCH v3 16/28] Revert "vhost-net: do not crash if backend is not present" |
Date: |
Wed, 6 Jul 2016 20:47:09 +0200 |
From: Marc-André Lureau <address@hidden>
Now that get_vhost_net() returns non-null after a successful
vhost_net_init(), we no longer need to check this case.
This reverts commit ecd34898596c60f79886061618dd7e01001113ad.
Signed-off-by: Marc-André Lureau <address@hidden>
---
hw/net/vhost_net.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
index 08c7d1e..f1dd367 100644
--- a/hw/net/vhost_net.c
+++ b/hw/net/vhost_net.c
@@ -428,15 +428,10 @@ VHostNetState *get_vhost_net(NetClientState *nc)
int vhost_set_vring_enable(NetClientState *nc, int enable)
{
VHostNetState *net = get_vhost_net(nc);
- const VhostOps *vhost_ops;
+ const VhostOps *vhost_ops = net->dev.vhost_ops;
nc->vring_enable = enable;
- if (!net) {
- return 0;
- }
-
- vhost_ops = net->dev.vhost_ops;
if (vhost_ops->vhost_set_vring_enable) {
return vhost_ops->vhost_set_vring_enable(&net->dev, enable);
}
--
2.9.0
- Re: [Qemu-devel] [PATCH v3 10/28] vhost: change some assert() for error_report() or silent fail, (continued)
[Qemu-devel] [PATCH v3 11/28] vhost: use error_report() instead of fprintf(stderr, ...), marcandre . lureau, 2016/07/06
[Qemu-devel] [PATCH v3 12/28] vhost-user: check qemu_chr_fe_set_msgfds() return value, marcandre . lureau, 2016/07/06
[Qemu-devel] [PATCH v3 13/28] vhost-user: check vhost_user_{read, write}() return value, marcandre . lureau, 2016/07/06
[Qemu-devel] [PATCH v3 14/28] qemu-char: check socket is actually connected, marcandre . lureau, 2016/07/06
[Qemu-devel] [PATCH v3 15/28] vhost-user: keep vhost_net after a disconnection, marcandre . lureau, 2016/07/06
[Qemu-devel] [PATCH v3 16/28] Revert "vhost-net: do not crash if backend is not present",
marcandre . lureau <=
[Qemu-devel] [PATCH v3 17/28] get_vhost_net() should be != null after vhost_user_init, marcandre . lureau, 2016/07/06
[Qemu-devel] [PATCH v3 18/28] vhost-net: success if backend has no ops->vhost_migration_done, marcandre . lureau, 2016/07/06
[Qemu-devel] [PATCH v3 19/28] vhost: add assert() to check runtime behaviour, marcandre . lureau, 2016/07/06
[Qemu-devel] [PATCH v3 20/28] char: add chr_wait_connected callback, marcandre . lureau, 2016/07/06
[Qemu-devel] [PATCH v3 21/28] char: add and use tcp_chr_wait_connected, marcandre . lureau, 2016/07/06
[Qemu-devel] [PATCH v3 22/28] vhost-user: wait until backend init is completed, marcandre . lureau, 2016/07/06
[Qemu-devel] [PATCH v3 23/28] tests: plug some leaks in virtio-net-test, marcandre . lureau, 2016/07/06
[Qemu-devel] [PATCH v3 25/28] tests: add /vhost-user/connect-fail test, marcandre . lureau, 2016/07/06