[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 00/10] 8bit AVR cores
From: |
Michael Rolnik |
Subject: |
Re: [Qemu-devel] [PATCH v9 00/10] 8bit AVR cores |
Date: |
Tue, 5 Jul 2016 21:15:44 +0300 |
Hi Richard,
Are there more pending issues with my code?
Thanks,
Michael
On Sat, Jul 2, 2016 at 10:56 PM, Michael Rolnik <address@hidden> wrote:
> for ADIW, SBIW instructions I modified address calculation.
>
> On Sat, Jul 2, 2016 at 9:20 PM, Michael Rolnik <address@hidden> wrote:
>
>> Hi Richard.
>>
>> I folded all my changes into prevous commits.
>>
>> 1. I meant EOR, which is actually XOR. Prevously it did not save the
>> result into the register
>> 2. my mistake I meant ORI and LDS and not ADIW, SBIW
>> 3. when there is a call to tlb_fill for [0x0000: 0x0100) region it
>> a. sets env->fullwr
>> b. calls cpu_loop_exit_restore.
>> c. the whole block is retranslated and instead of st it generates
>> helper_fullwr for each store within this TB.
>> d. helper_fullwr calls cpu_physical_memory_write
>> e. sample_io_write is called and register is changed since the whole
>> thing is done from within a helper
>> f. this is tested.
>>
>>
>> On Fri, Jul 1, 2016 at 10:09 PM, Richard Henderson <address@hidden>
>> wrote:
>>
>>> On 07/01/2016 07:47 AM, Michael Rolnik wrote:
>>>
>>>> 5. translation bug fixes for ADIW, SBIW, XOR instructions
>>>> 6. propper handling of cpu register writes though memory
>>>>
>>>
>>> I don't see these changes in the patch set.
>>>
>>>
>>> r~
>>>
>>
>>
>>
>> --
>> Best Regards,
>> Michael Rolnik
>>
>
>
>
> --
> Best Regards,
> Michael Rolnik
>
--
Best Regards,
Michael Rolnik
- [Qemu-devel] [PATCH v9 04/10] target-avr: adding instructions encodings, (continued)
- [Qemu-devel] [PATCH v9 04/10] target-avr: adding instructions encodings, Michael Rolnik, 2016/07/01
- [Qemu-devel] [PATCH v9 06/10] target-avr: adding helpers for IN, OUT, SLEEP, WBR & unsupported instructions, Michael Rolnik, 2016/07/01
- [Qemu-devel] [PATCH v9 07/10] target-avr: adding instruction decoder, Michael Rolnik, 2016/07/01
- [Qemu-devel] [PATCH v9 09/10] target-avr: updating translate.c to use instructions translation, Michael Rolnik, 2016/07/01
- [Qemu-devel] [PATCH v9 10/10] target-avr: decoder generator. currently not used by the build, can be used manually, Michael Rolnik, 2016/07/01
- [Qemu-devel] [PATCH v9 08/10] target-avr: adding instruction translation, Michael Rolnik, 2016/07/01
- Re: [Qemu-devel] [PATCH v9 00/10] 8bit AVR cores, Richard Henderson, 2016/07/01
- Re: [Qemu-devel] [PATCH v9 00/10] 8bit AVR cores, Michael Rolnik, 2016/07/02
- Re: [Qemu-devel] [PATCH v9 00/10] 8bit AVR cores, Michael Rolnik, 2016/07/02
- Re: [Qemu-devel] [PATCH v9 00/10] 8bit AVR cores,
Michael Rolnik <=
- Re: [Qemu-devel] [PATCH v9 00/10] 8bit AVR cores, Peter Maydell, 2016/07/05
- Re: [Qemu-devel] [PATCH v9 00/10] 8bit AVR cores, Michael Rolnik, 2016/07/05
- Re: [Qemu-devel] [PATCH v9 00/10] 8bit AVR cores, Peter Maydell, 2016/07/05
- Re: [Qemu-devel] [PATCH v9 00/10] 8bit AVR cores, Michael Rolnik, 2016/07/05
- Re: [Qemu-devel] [PATCH v9 00/10] 8bit AVR cores, Peter Maydell, 2016/07/05
- Re: [Qemu-devel] [PATCH v9 00/10] 8bit AVR cores, Michael Rolnik, 2016/07/05
- Re: [Qemu-devel] [PATCH v9 00/10] 8bit AVR cores, Peter Maydell, 2016/07/05
- Re: [Qemu-devel] [PATCH v9 00/10] 8bit AVR cores, Richard Henderson, 2016/07/05
- Re: [Qemu-devel] [PATCH v9 00/10] 8bit AVR cores, Michael Rolnik, 2016/07/06
- Re: [Qemu-devel] [PATCH v9 00/10] 8bit AVR cores, Peter Maydell, 2016/07/06