[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 7/7] trace: Add QAPI/QMP interfaces to query
From: |
Lluís Vilanova |
Subject: |
Re: [Qemu-devel] [PATCH v8 7/7] trace: Add QAPI/QMP interfaces to query and control per-vCPU tracing state |
Date: |
Tue, 05 Jul 2016 12:33:45 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Eric Blake writes:
> On 07/04/2016 03:41 AM, Lluís Vilanova wrote:
>> Signed-off-by: Lluís Vilanova <address@hidden>
>> Reviewed-by: Stefan Hajnoczi <address@hidden>
>> ---
>> hmp-commands-info.hx | 6 +-
>> hmp-commands.hx | 7 +-
>> monitor.c | 17 +++++-
>> qapi/trace.json | 32 +++++++++--
>> qmp-commands.hx | 35 +++++++++++-
>> trace/qmp.c | 148
>> ++++++++++++++++++++++++++++++++++++++++----------
>> 6 files changed, 202 insertions(+), 43 deletions(-)
>>
>> +++ b/qapi/trace.json
>> @@ -1,6 +1,6 @@
>> # -*- mode: python -*-
>> #
>> -# Copyright (C) 2011-2014 Lluís Vilanova <address@hidden>
>> +# Copyright (C) 2011-2016 Lluís Vilanova <address@hidden>
>> #
>> # This work is licensed under the terms of the GNU GPL, version 2 or later.
>> # See the COPYING file in the top-level directory.
>> @@ -29,11 +29,14 @@
>> #
>> # @name: Event name.
>> # @state: Tracing state.
>> +# @vcpu: Whether this is a per-vCPU event (since 2.7).
>> +#
>> +# An event is per-vCPU if it has the "vcpu" property in the "trace-events"
>> file.
> Is this comment still true, now that we've split trace-events into
> multiple files?
It is true for the few events we have now with this property. I can change it
to:
An event is per-vCPU if it has the "vcpu" property in the "trace-events"
files.
Note the plural in "files".
Cheers,
Lluis
- [Qemu-devel] [PATCH v8 0/7] trace: Per-vCPU tracing states, Lluís Vilanova, 2016/07/04
- [Qemu-devel] [PATCH v8 1/7] trace: Identify events with the 'vcpu' property, Lluís Vilanova, 2016/07/04
- [Qemu-devel] [PATCH v8 3/7] [trivial] trace: Cosmetic changes on fast-path tracing, Lluís Vilanova, 2016/07/04
- [Qemu-devel] [PATCH v8 5/7] trace: Conditionally trace events based on their per-vCPU state, Lluís Vilanova, 2016/07/04
- [Qemu-devel] [PATCH v8 4/7] trace: Add per-vCPU tracing states for events with the 'vcpu' property, Lluís Vilanova, 2016/07/04
- [Qemu-devel] [PATCH v8 6/7] trace: Allow event name pattern in "info trace-events", Lluís Vilanova, 2016/07/04
- [Qemu-devel] [PATCH v8 7/7] trace: Add QAPI/QMP interfaces to query and control per-vCPU tracing state, Lluís Vilanova, 2016/07/04
- [Qemu-devel] [PATCH v8 2/7] disas: Remove unused macro '_', Lluís Vilanova, 2016/07/04