|
From: | Peter Lieven |
Subject: | [Qemu-devel] Regression: block: Add .bdrv_co_pwrite_zeroes() |
Date: | Mon, 4 Jul 2016 15:49:09 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 |
Hi, the above commit: commit d05aa8bb4a8b6aa9a915ec5074fb12ae632d2323 Author: Eric Blake <address@hidden> Date: Wed Jun 1 15:10:03 2016 -0600 block: Add .bdrv_co_pwrite_zeroes() introduces a regression (at least for me). The Limits from the iSCSI Block Limits VPD have no requirement of being a power of two. We use Dell Equallogic iSCSI SANs for instance. They have an internal page size of 15MB. And they advertise this page size as max_ws_len, opt_transfer_len and opt_discard_alignment. I think we cannot assert that that these alignments are a power of 2. Peter
[Prev in Thread] | Current Thread | [Next in Thread] |