[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/2] mirror: fix misleading comments
From: |
Jeff Cody |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/2] mirror: fix misleading comments |
Date: |
Tue, 28 Jun 2016 22:57:08 -0400 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Thu, Jun 23, 2016 at 04:57:21PM +0800, Changlong Xie wrote:
> s/target bs/to_replace/, also we check to_replace bs is not
> blocked in qmp_drive_mirror() not here
>
> Signed-off-by: Changlong Xie <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
> ---
> block/mirror.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/mirror.c b/block/mirror.c
> index a04ed9c..4420a15 100644
> --- a/block/mirror.c
> +++ b/block/mirror.c
> @@ -769,7 +769,7 @@ static void mirror_complete(BlockJob *job, Error **errp)
> }
> }
>
> - /* check the target bs is not blocked and block all operations on it */
> + /* block all operations on to_replace bs */
> if (s->replaces) {
> AioContext *replace_aio_context;
>
> --
> 1.9.3
>
>
>
- [Qemu-devel] [PATCH v2 0/2] small fix of block job, Changlong Xie, 2016/06/23
- [Qemu-devel] [PATCH v2 1/2] blockjob: assert(cb) when create job, Changlong Xie, 2016/06/23
- [Qemu-devel] [PATCH v2 2/2] mirror: fix misleading comments, Changlong Xie, 2016/06/23
- Re: [Qemu-devel] [PATCH v2 2/2] mirror: fix misleading comments,
Jeff Cody <=
- Re: [Qemu-devel] [PATCH v2 0/2] small fix of block job, Fam Zheng, 2016/06/23
- Re: [Qemu-devel] [PATCH v2 0/2] small fix of block job, Stefan Hajnoczi, 2016/06/24
- Re: [Qemu-devel] [PATCH v2 0/2] small fix of block job, Jeff Cody, 2016/06/28