|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH 2/3] ide: ignore retry_unit check for non-retry operations |
Date: | Tue, 28 Jun 2016 22:56:46 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 24/06/2016 17:06, Denis V. Lunev wrote: > When doing DMA request ide/core.c will set s->retry_unit to s->unit in > ide_start_dma. When dma completes ide_set_inactive sets retry_unit to -1. > After that ide_flush_cache runs and fails thanks to blkdebug. > ide_flush_cb calls ide_handle_rw_error which asserts that s->retry_unit > == s->unit. But s->retry_unit is still -1 after previous DMA completion > and flush does not use anything related to retry. Wouldn't the assertion fail for a PIO read/write too? Perhaps retry_unit should be set to s->unit in ide_transfer_start too. Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |