[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v3 16/19] tcg: move locking for tb_invalidate_phys
From: |
Sergey Fedorov |
Subject: |
Re: [Qemu-devel] [RFC v3 16/19] tcg: move locking for tb_invalidate_phys_page_range up |
Date: |
Tue, 28 Jun 2016 22:43:08 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 |
On 03/06/16 23:40, Alex Bennée wrote:
> While we previously assumed an existing memory lock protected the page
> look up in the MTTCG SoftMMU case the memory lock is provided by the
> tb_lock. As a result we push the taking of this lock up the call tree.
> This requires a slightly different entry for the SoftMMU and user-mode
> cases from tb_invalidate_phys_range.
Sorry, I can't understand the description for the patch :( Some
rewording might be helpful, if you don't mind.
Thanks,
Sergey
> This also means user-mode breakpoint insertion needs to take two locks
> but it hadn't taken any previously so this is an improvement.
>
> Signed-off-by: Alex Bennée <address@hidden>
> ---
> exec.c | 16 ++++++++++++++++
> translate-all.c | 37 +++++++++++++++++++++++++++++--------
> 2 files changed, 45 insertions(+), 8 deletions(-)
(snip)
- Re: [Qemu-devel] [RFC v3 14/19] tcg: remove global exit_request, (continued)
- [Qemu-devel] [RFC v3 09/19] target-arm/arm-powerctl: wake up sleeping CPUs, Alex Bennée, 2016/06/03
- [Qemu-devel] [RFC v3 10/19] tcg: cpus rm tcg_exec_all(), Alex Bennée, 2016/06/03
- [Qemu-devel] [RFC v3 18/19] tcg: Ensure safe TB lookup out of 'tb_lock', Alex Bennée, 2016/06/03
- [Qemu-devel] [RFC v3 17/19] tcg: enable thread-per-vCPU, Alex Bennée, 2016/06/03
- [Qemu-devel] [RFC v3 15/19] tcg: drop global lock during TCG code execution, Alex Bennée, 2016/06/03
- [Qemu-devel] [RFC v3 19/19] cpu-exec: remove tb_lock from the hot-path, Alex Bennée, 2016/06/03
- [Qemu-devel] [RFC v3 16/19] tcg: move locking for tb_invalidate_phys_page_range up, Alex Bennée, 2016/06/03
- Re: [Qemu-devel] [RFC v3 16/19] tcg: move locking for tb_invalidate_phys_page_range up,
Sergey Fedorov <=
- Re: [Qemu-devel] [RFC v3 00/19] Base enabling patches for MTTCG, Pranith Kumar, 2016/06/04