[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 4/9] virtio-blk: multiqueue batch notify
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PULL 4/9] virtio-blk: multiqueue batch notify |
Date: |
Tue, 28 Jun 2016 14:23:26 +0100 |
The batch notification BH needs to know which virtqueues to notify when
multiqueue is enabled. Use a bitmap to track the virtqueues with
pending notifications.
At this point there is only one virtqueue so hard-code virtqueue index
0. A later patch will switch to real virtqueue indices.
Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
hw/block/dataplane/virtio-blk.c | 29 +++++++++++++++++++++++------
1 file changed, 23 insertions(+), 6 deletions(-)
diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c
index 2041b04..c20a195 100644
--- a/hw/block/dataplane/virtio-blk.c
+++ b/hw/block/dataplane/virtio-blk.c
@@ -34,8 +34,8 @@ struct VirtIOBlockDataPlane {
VirtIODevice *vdev;
VirtQueue *vq; /* virtqueue vring */
- EventNotifier *guest_notifier; /* irq */
QEMUBH *bh; /* bh for guest notification */
+ unsigned long *batch_notify_vqs;
/* Note that these EventNotifiers are assigned by value. This is
* fine as long as you do not call event_notifier_cleanup on them
@@ -49,18 +49,34 @@ struct VirtIOBlockDataPlane {
/* Raise an interrupt to signal guest, if necessary */
void virtio_blk_data_plane_notify(VirtIOBlockDataPlane *s)
{
+ set_bit(0, s->batch_notify_vqs);
qemu_bh_schedule(s->bh);
}
static void notify_guest_bh(void *opaque)
{
VirtIOBlockDataPlane *s = opaque;
+ unsigned nvqs = s->conf->num_queues;
+ unsigned long bitmap[BITS_TO_LONGS(nvqs)];
+ unsigned j;
- if (!virtio_should_notify(s->vdev, s->vq)) {
- return;
+ memcpy(bitmap, s->batch_notify_vqs, sizeof(bitmap));
+ memset(s->batch_notify_vqs, 0, sizeof(bitmap));
+
+ for (j = 0; j < nvqs; j += BITS_PER_LONG) {
+ unsigned long bits = bitmap[j];
+
+ while (bits != 0) {
+ unsigned i = j + ctzl(bits);
+ VirtQueue *vq = virtio_get_queue(s->vdev, i);
+
+ if (virtio_should_notify(s->vdev, vq)) {
+ event_notifier_set(virtio_queue_get_guest_notifier(vq));
+ }
+
+ bits &= bits - 1; /* clear right-most bit */
+ }
}
-
- event_notifier_set(s->guest_notifier);
}
/* Context: QEMU global mutex held */
@@ -104,6 +120,7 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev,
VirtIOBlkConf *conf,
}
s->ctx = iothread_get_aio_context(s->iothread);
s->bh = aio_bh_new(s->ctx, notify_guest_bh, s);
+ s->batch_notify_vqs = bitmap_new(conf->num_queues);
*dataplane = s;
}
@@ -116,6 +133,7 @@ void virtio_blk_data_plane_destroy(VirtIOBlockDataPlane *s)
}
virtio_blk_data_plane_stop(s);
+ g_free(s->batch_notify_vqs);
qemu_bh_delete(s->bh);
object_unref(OBJECT(s->iothread));
g_free(s);
@@ -154,7 +172,6 @@ void virtio_blk_data_plane_start(VirtIOBlockDataPlane *s)
"ensure -enable-kvm is set\n", r);
goto fail_guest_notifiers;
}
- s->guest_notifier = virtio_queue_get_guest_notifier(s->vq);
/* Set up virtqueue notify */
r = virtio_bus_set_host_notifier(VIRTIO_BUS(qbus), 0, true);
--
2.7.4
- [Qemu-devel] [PULL 0/9] Block patches, Stefan Hajnoczi, 2016/06/28
- [Qemu-devel] [PULL 1/9] Revert "virtio: sync the dataplane vring state to the virtqueue before virtio_save", Stefan Hajnoczi, 2016/06/28
- [Qemu-devel] [PULL 4/9] virtio-blk: multiqueue batch notify,
Stefan Hajnoczi <=
- [Qemu-devel] [PULL 5/9] virtio-blk: tell dataplane which vq to notify, Stefan Hajnoczi, 2016/06/28
- [Qemu-devel] [PULL 2/9] dma-helpers: dma_blk_io() cancel support, Stefan Hajnoczi, 2016/06/28
- [Qemu-devel] [PULL 6/9] virtio-blk: associate request with a virtqueue, Stefan Hajnoczi, 2016/06/28
- [Qemu-devel] [PULL 7/9] virtio-blk: live migrate s->rq with multiqueue, Stefan Hajnoczi, 2016/06/28
- [Qemu-devel] [PULL 3/9] virtio-blk: add VirtIOBlockConf->num_queues, Stefan Hajnoczi, 2016/06/28
- [Qemu-devel] [PULL 9/9] virtio-blk: add num-queues device property, Stefan Hajnoczi, 2016/06/28
- [Qemu-devel] [PULL 8/9] virtio-blk: dataplane multiqueue support, Stefan Hajnoczi, 2016/06/28
- Re: [Qemu-devel] [PULL 0/9] Block patches, Peter Maydell, 2016/06/28