[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/12] monitor: remove usage of generated marsha
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 04/12] monitor: remove usage of generated marshal functions |
|
Date: |
Fri, 24 Jun 2016 08:59:43 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 06/24/2016 08:14 AM, Marc-André Lureau wrote:
> Hi
>
> On Fri, Jun 24, 2016 at 6:23 AM, Eric Blake <address@hidden> wrote:
>>>
>>> -static bool invalid_qmp_mode(const Monitor *mon, const mon_cmd_t *cmd,
>>> +static bool invalid_qmp_mode(const Monitor *mon, const gchar *cmd,
>>
>> Why 'gchar'? What's wrong with 'char'? (Some of glib's typedefs make
>> sense, but gchar is not one of them)
>
> just some old habit, fixed.
>
> ack otherwise?
Yes, you can add:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 00/12] qapi: remove the 'middle' mode, marcandre . lureau, 2016/06/22
- [Qemu-devel] [PATCH 02/12] qapi-schema: add 'device_add', marcandre . lureau, 2016/06/22
- [Qemu-devel] [PATCH 01/12] qapi-schema: use generated marshaller for 'qmp_capabilities', marcandre . lureau, 2016/06/22
- [Qemu-devel] [PATCH 05/12] monitor: register the qapi generated commands, marcandre . lureau, 2016/06/22
- [Qemu-devel] [PATCH 07/12] monitor: implement 'qmp_query_commands' without qmp_cmds, marcandre . lureau, 2016/06/22