[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 4/5] include: Move typedef qemu_irq to qemu/
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH RFC 4/5] include: Move typedef qemu_irq to qemu/typedefs.h |
Date: |
Fri, 24 Jun 2016 10:17:54 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 24/06/2016 10:15, Peter Maydell wrote:
>>>> >>> @@ -31,6 +31,7 @@ typedef struct FWCfgState FWCfgState;
>>>> >>> typedef struct HCIInfo HCIInfo;
>>>> >>> typedef struct I2CBus I2CBus;
>>>> >>> typedef struct I2SCodec I2SCodec;
>>>> >>> +typedef struct IRQState *qemu_irq;
>>>> >>> typedef struct ISABus ISABus;
>>>> >>> typedef struct ISADevice ISADevice;
>>>> >>> typedef struct IsaDma IsaDma;
>>> >>
>>> >> Everything else in typedefs.h is a "typedef struct Thing Thing",
>>> >> but qemu_irq is different...
>> >
>> > We want to keep our readers on their toes!
> It would mean you now have to decide whether the file is orderd
> by the types being defined or by the underlying implementation
> type (previously both orders were the same)...
Indeed, and renaming the struct is trivial because it's used in a
handful of places only.
Paolo
- [Qemu-devel] [PATCH RFC 0/5] Baby steps towards saner headers, Markus Armbruster, 2016/06/23
- [Qemu-devel] [PATCH RFC 4/5] include: Move typedef qemu_irq to qemu/typedefs.h, Markus Armbruster, 2016/06/23
- Re: [Qemu-devel] [PATCH RFC 4/5] include: Move typedef qemu_irq to qemu/typedefs.h, Peter Maydell, 2016/06/23
- Re: [Qemu-devel] [PATCH RFC 4/5] include: Move typedef qemu_irq to qemu/typedefs.h, Markus Armbruster, 2016/06/24
- Re: [Qemu-devel] [PATCH RFC 4/5] include: Move typedef qemu_irq to qemu/typedefs.h, Peter Maydell, 2016/06/24
- Re: [Qemu-devel] [PATCH RFC 4/5] include: Move typedef qemu_irq to qemu/typedefs.h,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH RFC 4/5] include: Move typedef qemu_irq to qemu/typedefs.h, Peter Maydell, 2016/06/24
- Re: [Qemu-devel] [PATCH RFC 4/5] include: Move typedef qemu_irq to qemu/typedefs.h, Markus Armbruster, 2016/06/24
- Re: [Qemu-devel] [PATCH RFC 4/5] include: Move typedef qemu_irq to qemu/typedefs.h, Peter Maydell, 2016/06/24
- Re: [Qemu-devel] [PATCH RFC 4/5] include: Move typedef qemu_irq to qemu/typedefs.h, Markus Armbruster, 2016/06/24
- Re: [Qemu-devel] [PATCH RFC 4/5] include: Move typedef qemu_irq to qemu/typedefs.h, Peter Maydell, 2016/06/24
[Qemu-devel] [PATCH RFC 3/5] include/qemu/typedefs.h: Restore alphabetical order, Markus Armbruster, 2016/06/23
[Qemu-devel] [PATCH RFC 1/5] Use #include "..." exactly for our own headers, Markus Armbruster, 2016/06/23