[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 07/22] scsi: Advertise limits by blocksize, n
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v3 07/22] scsi: Advertise limits by blocksize, not 512 |
Date: |
Fri, 24 Jun 2016 13:22:03 +0800 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Thu, 06/23 16:37, Eric Blake wrote:
> s->blocksize may be larger than 512, in which case our
> tweaks to max_xfer_len and opt_xfer_len must be scaled
> appropriately.
>
> Reported-by: Fam Zheng <address@hidden>
> Signed-off-by: Eric Blake <address@hidden>
> CC: address@hidden
>
> ---
> v3: new patch
> ---
> hw/scsi/scsi-generic.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/scsi/scsi-generic.c b/hw/scsi/scsi-generic.c
> index 6a2d89a..75e227d 100644
> --- a/hw/scsi/scsi-generic.c
> +++ b/hw/scsi/scsi-generic.c
> @@ -225,7 +225,8 @@ static void scsi_read_complete(void * opaque, int ret)
> if (s->type == TYPE_DISK &&
> r->req.cmd.buf[0] == INQUIRY &&
> r->req.cmd.buf[2] == 0xb0) {
> - uint32_t max_xfer_len = blk_get_max_transfer_length(s->conf.blk);
> + uint32_t max_xfer_len = blk_get_max_transfer_length(s->conf.blk) /
> + (s->blocksize / BDRV_SECTOR_SIZE);
> if (max_xfer_len) {
> stl_be_p(&r->buf[8], max_xfer_len);
> /* Also take care of the opt xfer len. */
> --
> 2.5.5
>
Reviewed-by: Fam Zheng <address@hidden>
- [Qemu-devel] [PATCH v3 00/22] Byte-based block limits, Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 04/22] nbd: Allow larger requests, Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 09/22] blkdebug: Set request_alignment during .bdrv_refresh_limits(), Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 08/22] block: Give nonzero result to blk_get_max_transfer_length(), Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 02/22] block: Document supported flags during bdrv_aligned_preadv(), Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 06/22] iscsi: Advertise realistic limits to block layer, Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 05/22] nbd: Advertise realistic limits to block layer, Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 07/22] scsi: Advertise limits by blocksize, not 512, Eric Blake, 2016/06/23
- Re: [Qemu-devel] [PATCH v3 07/22] scsi: Advertise limits by blocksize, not 512,
Fam Zheng <=
- [Qemu-devel] [PATCH v3 01/22] block: Tighter assertions on bdrv_aligned_pwritev(), Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 13/22] block: Set request_alignment during .bdrv_refresh_limits(), Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 10/22] iscsi: Set request_alignment during .bdrv_refresh_limits(), Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 15/22] block: Switch transfer length bounds to byte-based, Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 17/22] block: Switch discard length bounds to byte-based, Eric Blake, 2016/06/23
- [Qemu-devel] [PATCH v3 14/22] block: Set default request_alignment during bdrv_refresh_limits(), Eric Blake, 2016/06/23