[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/10] globals: Clean up validation and error
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/10] globals: Clean up validation and error checking |
Date: |
Wed, 22 Jun 2016 19:12:06 -0300 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
Markus, all patches in this series got at least one Reviewed-by
line. I would like to have your Acked-by to merge it through my
tree, so I can apply Igor's -cpu + global property series that
depend on it.
On Mon, Jun 20, 2016 at 12:52:53PM -0300, Eduardo Habkost wrote:
> This series includes multiple changes to the way errors are
> handled by the global property system.
>
> Git tree:
> https://github.com/ehabkost/qemu-hacks.git work/global-error-handling
>
> Changes v1 -> v2:
> * Fix test-qdev-global-props unit test
> * Remove subprocess code and "nouser" test case
> * Reported-by: Igor Mammedov <address@hidden>
> * Reword doc comments for GlobalProperty::errp
> * Suggested-by: Markus Armbruster <address@hidden>
> * Squashed "Use error_prepend() for errors applying globals"
> and "qdev: GlobalProperty.errp field"
> * Suggested-by: Markus Armbruster <address@hidden>
> * Simplify object_class_dynamic_cast(oc, TYPE_DEVICE) checks
> * Suggested-by: Markus Armbruster <address@hidden>
> * New patch: "qdev: Remove qdev_prop_register_global_list()"
>
> Eduardo Habkost (10):
> qdev: Don't stop applying globals on first error
> qdev: Eliminate qemu_add_globals() function
> vl: Reject invalid class names on -global
> qdev: GlobalProperty.errp field
> machine: Add machine_register_compat_props() function
> vl: Set errp to &error_abort on machine compat_props
> qdev: Eliminate "global not used" warning
> qdev: Eliminate GlobalProperty 'used' and 'user_provided' fields
> qdev: Remove qdev_prop_register_global_list()
> machine: Skip global registration for non-existing classes
>
> hw/core/machine.c | 26 +++++++++
> hw/core/qdev-properties-system.c | 21 +------
> hw/core/qdev-properties.c | 55 +++----------------
> include/hw/boards.h | 1 +
> include/hw/qdev-core.h | 9 ++-
> include/hw/qdev-properties.h | 2 -
> include/qemu/config-file.h | 1 -
> tests/test-qdev-global-props.c | 115
> ++++-----------------------------------
> vl.c | 37 ++++++++++---
> 9 files changed, 80 insertions(+), 187 deletions(-)
>
> --
> 2.5.5
>
--
Eduardo