[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/15] stream: Fix prototype of stream_start()
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH 01/15] stream: Fix prototype of stream_start() |
Date: |
Mon, 20 Jun 2016 18:07:16 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 09.06.2016 10:20, Alberto Garcia wrote:
> 'stream-start' has a parameter called 'backing-file', which is the
> string to be written to bs->backing when the job finishes.
>
> In the stream_start() implementation it is called 'backing_file_str',
> but it the prototype in the header file it is called 'base_id'.
>
> This patch fixes it so the name is the same in both cases and is
> consistent with other cases (like commit_start()).
>
> Signed-off-by: Alberto Garcia <address@hidden>
> ---
> include/block/block_int.h | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 09/15] stream: Add 'job-id' parameter to 'block-commit', (continued)
- [Qemu-devel] [PATCH 06/15] mirror: Add 'job-id' parameter to 'blockdev-mirror' and 'drive-mirror', Alberto Garcia, 2016/06/09
- [Qemu-devel] [PATCH 05/15] blockjob: Add 'job_id' parameter to block_job_create(), Alberto Garcia, 2016/06/09
- [Qemu-devel] [PATCH 13/15] blockjob: Add 'id' parameter to 'block-job-resume', Alberto Garcia, 2016/06/09
- [Qemu-devel] [PATCH 01/15] stream: Fix prototype of stream_start(), Alberto Garcia, 2016/06/09
- Re: [Qemu-devel] [PATCH 01/15] stream: Fix prototype of stream_start(),
Max Reitz <=
- [Qemu-devel] [PATCH 11/15] blockjob: Add 'id' parameter to 'block-job-cancel', Alberto Garcia, 2016/06/09
- [Qemu-devel] [PATCH 02/15] blockjob: Decouple the ID from the device name in the BlockJob struct, Alberto Garcia, 2016/06/09
- [Qemu-devel] [PATCH 04/15] block: Simplify find_block_job() and make it accept a job ID, Alberto Garcia, 2016/06/09