[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v3 PATCH 14/14] target-i386: Generate fences for x
|
From: |
Pranith Kumar |
|
Subject: |
Re: [Qemu-devel] [RFC v3 PATCH 14/14] target-i386: Generate fences for x86 |
|
Date: |
Mon, 20 Jun 2016 11:05:51 -0400 |
On Sat, Jun 18, 2016 at 1:48 AM, Richard Henderson <address@hidden> wrote:
> On 06/17/2016 09:03 PM, Pranith Kumar wrote:
>>
>> case 0xe8 ... 0xef: /* lfence */
>> + tcg_gen_mb(TCG_MO_LD_LD | TCG_BAR_SC);
>> + break;
>> case 0xf0 ... 0xf7: /* mfence */
>> if (!(s->cpuid_features & CPUID_SSE2)
>> || (prefixes & PREFIX_LOCK)) {
>> goto illegal_op;
>> }
>> + tcg_gen_mb(TCG_MO_ALL | TCG_BAR_SC);
>
>
> You need to duplicate the sse2 check if you split lfence from mfence.
>
Yes, I missed this one. I will fix it.
Thanks for the review.
--
Pranith