[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/10] globals: Clean up validation and error ch
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH 00/10] globals: Clean up validation and error checking |
Date: |
Mon, 20 Jun 2016 15:11:00 +0200 |
On Wed, 15 Jun 2016 17:32:43 -0300
Eduardo Habkost <address@hidden> wrote:
> This series includes multiple changes to the way errors are
> handled by the global property system.
Could you fix "make check",
by the end of series it breaks at compile time.
>
> The series is based on my machine-next branch, available at:
> https://github.com/ehabkost/qemu.git machine-next
>
> The series itself can be found at:
> https://github.com/ehabkost/qemu-hacks.git
> work/global-error-handling
>
> Eduardo Habkost (10):
> qdev: Don't stop applying globals on first error
> qdev: Eliminate qemu_add_globals() function
> vl: Reject invalid class names on -global
> qdev: Use error_prepend() for errors applying globals
> qdev: GlobalProperty.errp field
> machine: Add machine_register_compat_props() function
> vl: Set errp to &error_abort on machine compat_props
> qdev: Eliminate "global not used" warning
> qdev: Eliminate GlobalProperty 'used' and 'user_provided' fields
> machine: Skip global registration for non-existing classes
>
> hw/core/machine.c | 27 +++++++++++++++++++++++
> hw/core/qdev-properties-system.c | 21 +-----------------
> hw/core/qdev-properties.c | 46
> ++++++----------------------------------
> include/hw/boards.h | 1 +
> include/hw/qdev-core.h | 9 ++++----
> include/hw/qdev-properties.h | 1 -
> include/qemu/config-file.h | 1 -
> vl.c | 38
> ++++++++++++++++++++++++++------- 8 files changed, 70 insertions(+),
> 74 deletions(-)
>