[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/5] hw/net/rocker: Don't use *_to_cpup()
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH 3/5] hw/net/rocker: Don't use *_to_cpup() |
Date: |
Thu, 16 Jun 2016 18:17:24 +0100 |
Don't use *_to_cpup() to do byte-swapped loads; instead use
ld*_p() which correctly handle misaligned accesses.
Signed-off-by: Peter Maydell <address@hidden>
---
hw/net/rocker/rocker_tlv.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/net/rocker/rocker_tlv.h b/hw/net/rocker/rocker_tlv.h
index e3c4ab6..8856164 100644
--- a/hw/net/rocker/rocker_tlv.h
+++ b/hw/net/rocker/rocker_tlv.h
@@ -106,17 +106,17 @@ static inline uint64_t rocker_tlv_get_u64(const RockerTlv
*tlv)
static inline uint16_t rocker_tlv_get_le16(const RockerTlv *tlv)
{
- return le16_to_cpup((uint16_t *) rocker_tlv_data(tlv));
+ return lduw_le_p(rocker_tlv_data(tlv));
}
static inline uint32_t rocker_tlv_get_le32(const RockerTlv *tlv)
{
- return le32_to_cpup((uint32_t *) rocker_tlv_data(tlv));
+ return ldl_le_p(rocker_tlv_data(tlv));
}
static inline uint64_t rocker_tlv_get_le64(const RockerTlv *tlv)
{
- return le64_to_cpup((uint64_t *) rocker_tlv_data(tlv));
+ return ldq_le_p(rocker_tlv_data(tlv));
}
static inline void rocker_tlv_parse(RockerTlv **tb, int maxtype,
--
1.9.1
- [Qemu-devel] [PATCH 0/5] hw/net: Don't use cpu_to_*w() and *_to_cpup(), Peter Maydell, 2016/06/16
- [Qemu-devel] [PATCH 2/5] hw/net/rtl8139.c: Don't use *_to_cpup(), Peter Maydell, 2016/06/16
- [Qemu-devel] [PATCH 1/5] hw/net/eepro100.c: Don't use cpu_to_*w() and *_to_cpup(), Peter Maydell, 2016/06/16
- [Qemu-devel] [PATCH 4/5] hw/net/virtio-net.c: Don't use *_to_cpup(), Peter Maydell, 2016/06/16
- [Qemu-devel] [PATCH 3/5] hw/net/rocker: Don't use *_to_cpup(),
Peter Maydell <=
- [Qemu-devel] [PATCH 5/5] hw/net/e1000: Don't use *_to_cpup(), Peter Maydell, 2016/06/16
- Re: [Qemu-devel] [PATCH 0/5] hw/net: Don't use cpu_to_*w() and *_to_cpup(), Richard Henderson, 2016/06/17
- Re: [Qemu-devel] [PATCH 0/5] hw/net: Don't use cpu_to_*w() and *_to_cpup(), Jason Wang, 2016/06/19
- Re: [Qemu-devel] [PATCH 0/5] hw/net: Don't use cpu_to_*w() and *_to_cpup(), Peter Maydell, 2016/06/27