[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 0/5] blockjob: AioContext change support for
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v4 0/5] blockjob: AioContext change support for mirror and backup |
Date: |
Wed, 15 Jun 2016 10:59:59 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 14/06/2016 20:17, Stefan Hajnoczi wrote:
> v4:
> * Add .pause()/.resume() callbacks to really quiesce during
> block_job_pause_point() [Paolo]
> * Add AioContext change support for backup block job
> * Tested drive_mirror + migration and drive_backup + reboot
Also a nice improvement over v3!
I think the description of job->busy can be improved further and, more
important, I am not sure that mirror_pause is correct. While you are at
it, you could annotate mirror_pause and (*pause) as coroutine_fn.
But anyway, apart from this
Reviewed-by: Paolo Bonzini <address@hidden>
Paolo
- Re: [Qemu-devel] [PATCH v4 2/5] blockjob: add pause points, (continued)