[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] Use "-s" instead of "--quiet" to resolve non
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2] Use "-s" instead of "--quiet" to resolve non-fatal build error on FreeBSD. |
Date: |
Tue, 14 Jun 2016 16:11:42 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 06/14/2016 12:07 PM, Sean Bruno wrote:
> The --quiet argument is not available on all operating systems. Use -s
> instead to match the rest of the Makefile uses. This fixes a non-fatal
> error seen on FreeBSD.
>
> Signed-off-by: Sean Bruno <address@hidden>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
See also my pending patch related to this code:
https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg02375.html
if Paolo wants to pull in all the changes related to version generation
in his next pull request.
>
> diff --git a/Makefile b/Makefile
> index ed4032a..a7a356a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -185,7 +185,7 @@ qemu-version.h: FORCE
> printf '""\n'; \
> fi; \
> fi) > address@hidden)
> - $(call quiet-command, cmp --quiet $@ address@hidden || mv
> address@hidden $@)
> + $(call quiet-command, cmp -s $@ address@hidden || mv address@hidden $@)
>
> config-host.h: config-host.h-timestamp
> config-host.h-timestamp: config-host.mak
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature