Re: [Qemu-devel] [PATCH v2 0/2] block: fix libvirt snapshot with existing bitmaps

[Max Reitz]

On 14.06.2016 19:08, Vladimir Sementsov-Ogievskiy wrote:
> v2:
>  - additional patch with asserts for hbitmap. As BdrvDirtyBitmap is only
>    an interlayer here, I decided to plase asserts into HBitmap public
>    functions.
>  - add comment
>  - from Max's comments:
>     - assert after if block
>     - bitmap->size instead of bdrv_nb_sectors. It is not beautiful, but
>       with bdrv_nb_sectors we have to handle error code here, which
>       would be worse I think.
> 
> Vladimir Sementsov-Ogievskiy (2):
>   hbitmap: add 'pos < size' asserts
>   block: fix libvirt snapshot with existing bitmaps
> 
>  block/dirty-bitmap.c | 14 ++++++++++++++
>  util/hbitmap.c       |  3 +++
>  2 files changed, 17 insertions(+)

Thanks Vladimir, I've applied the series to my block branch:

https://github.com/XanClic/qemu/commits/block

Max

signature.asc
Description: OpenPGP digital signature