Re: [Qemu-devel] [PATCH 1/5] configure: Don't override ARCH=unknown if enabling TCI

[Laurent Vivier]

Le 14/06/2016 à 11:52, Peter Maydell a écrit :
> At the moment if configure finds an unknown CPU it will set
> ARCH to 'unknown', and then later either bail out or set it
> to 'tci' (depending on whether the user passed configure the
> --enable-tcg-interpreter switch). This is unnecessarily
> confusing, because we could be using TCI in two cases:
>  * a known host architecture (in which case ARCH is set to
>    the actual host architecture, like 'i386')
>  * an unknown host architecture (in which case ARCH is
>    set to 'tci')
> so nothing can rely on ARCH=tci to mean "using TCI".
> Remove the line setting ARCH, so we leave it as "unknown",
> which is what the actual situation is.
> 
> Signed-off-by: Peter Maydell <address@hidden>

Reviewed-by: Laurent Vivier <address@hidden>

> ---
>  configure | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 8c2f90b..7ab4e0b 100755
> --- a/configure
> +++ b/configure
> @@ -1381,7 +1381,6 @@ fi
>  if test "$ARCH" = "unknown"; then
>      if test "$tcg_interpreter" = "yes" ; then
>          echo "Unsupported CPU = $cpu, will use TCG with TCI (experimental)"
> -        ARCH=tci
>      else
>          error_exit "Unsupported CPU = $cpu, try --enable-tcg-interpreter"
>      fi
>