qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [Bug 1589564] Re: qemu/hw/scsi/scsi-disk.c:2741: possible m


From: dcb
Subject: [Qemu-devel] [Bug 1589564] Re: qemu/hw/scsi/scsi-disk.c:2741: possible missing break ?
Date: Sat, 11 Jun 2016 08:13:49 -0000

>I am currently not able to reproduce the problem with the format strings ... 
>how did you get them? Which compiler (and version) did you use?

I used a static analyser for C & C++ called cppcheck. It is available
from sourceforge. I find it very useful.

I think gcc might be able to reproduce these problems with one of the
higher warning levels. -Wformat=2 springs to mind, but a check of the gcc
documentation around -Wformat will give more accurate guidance.

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1589564

Title:
  qemu/hw/scsi/scsi-disk.c:2741: possible missing break ?

Status in QEMU:
  New

Bug description:
  qemu/hw/scsi/scsi-disk.c:2741] -> [qemu/hw/scsi/scsi-disk.c:2745]: (warning) 
Variable 'cdb1' is reassigned a value before the old one has been used. 
'break;' missing?
  qemu/hw/scsi/scsi-disk.c:2742] -> [qemu/hw/scsi/scsi-disk.c:2746]: (warning) 
Variable 'group_number' is reassigned a value before the old one has been used. 
'break;' missing?

  Source code is

      case 1:
          /* 10-byte CDB.  */
          r->cdb1 = req->cmd.buf[1];
          r->group_number = req->cmd.buf[6];
      case 4:
          /* 12-byte CDB.  */

  Also,

  [qemu/hw/scsi/scsi-disk.c:2063]: (warning) %lu in format string (no. 1) 
requires 'unsigned long' but the argument type is 'signed long'.
  [qemu/hw/scsi/scsi-disk.c:2066]: (warning) %lu in format string (no. 1) 
requires 'unsigned long' but the argument type is 'signed long'.
  [qemu/hw/scsi/scsi-disk.c:2069]: (warning) %lu in format string (no. 1) 
requires 'unsigned long' but the argument type is 'signed long'.
  [qemu/hw/scsi/scsi-disk.c:2083]: (warning) %lu in format string (no. 2) 
requires 'unsigned long' but the argument type is 'signed long'.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1589564/+subscriptions



reply via email to

[Prev in Thread] Current Thread [Next in Thread]