qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/2] Explicitly print out default vnc option in


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 2/2] Explicitly print out default vnc option in use
Date: Tue, 31 May 2016 09:51:12 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Robert Ho <address@hidden> writes:

> If no display option defined in QEMU command line, and SDL is not
> available, then it by default uses '-vnc localhost:0,to=99,id=default'.
> This patch simply print out the default option parameters out, so that
> user is aware of that.
>
> Signed-off-by: Robert Ho <address@hidden>
> ---
>  vl.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/vl.c b/vl.c
> index 18d1423..8617a68 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4213,7 +4213,10 @@ int main(int argc, char **argv, char **envp)
>  #elif defined(CONFIG_COCOA)
>          display_type = DT_COCOA;
>  #elif defined(CONFIG_VNC)
> -        vnc_parse("localhost:0,to=99,id=default", &error_abort);
> +             #define DEFAULT_VNC_DISPLAY_OPTION      
> "localhost:0,to=99,id=default"

Preprocessor directives shouldn't be indented.

Also tab damage.  Please use scripts/checkpatch.pl to check your patches.

> +        vnc_parse(DEFAULT_VNC_DISPLAY_OPTION, &error_abort);
> +             printf("No display option defined, using '-vnc %s' by default   
> \
> +\n", DEFAULT_VNC_DISPLAY_OPTION);
>          show_vnc_port = 1;
>  #else
>          display_type = DT_NONE;

I don't like this.  Programs should be quiet unless they got something
important to say.  Can't see why this particular default is more
important than all the other defaults we don't print.

The default could be documented in output of --help.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]