[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 7/9] virtio-blk: live migrate s->rq with multiqu
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 7/9] virtio-blk: live migrate s->rq with multiqueue |
Date: |
Fri, 27 May 2016 14:42:22 -0700 |
User-agent: |
Mutt/1.6.0 (2016-04-01) |
On Sat, May 21, 2016 at 05:37:27PM +0200, Paolo Bonzini wrote:
>
>
> On 21/05/2016 01:40, Stefan Hajnoczi wrote:
> > while (req) {
> > qemu_put_sbyte(f, 1);
>
> Could you just put an extra 32-bit queue id here if num_queues > 1? A
> guest with num_queues > 1 cannot be started on pre-2.7 QEMU, so you can
> change the migration format (if virtio were using vmstate, it would be a
> VMSTATE_UINT32_TEST).
That's a good point: the same command-line would not work on old QEMU so
there is no possibility of new->old migration in the first place!
Your solution is much simpler than my hack (which took me a long time to
find and I was kind of proud of). Will change for v2.
Stefan
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH 5/9] virtio-blk: multiqueue batch notify, (continued)
- [Qemu-devel] [PATCH 4/9] virtio-blk: add VirtIOBlockConf->num_queues, Stefan Hajnoczi, 2016/05/20
- [Qemu-devel] [PATCH 6/9] vmstate: add VMSTATE_VARRAY_UINT32_ALLOC, Stefan Hajnoczi, 2016/05/20
- [Qemu-devel] [PATCH 7/9] virtio-blk: live migrate s->rq with multiqueue, Stefan Hajnoczi, 2016/05/20
- [Qemu-devel] [PATCH 9/9] virtio-blk: add num-queues device property, Stefan Hajnoczi, 2016/05/20
- [Qemu-devel] [PATCH 8/9] virtio-blk: dataplane multiqueue support, Stefan Hajnoczi, 2016/05/20
- Re: [Qemu-devel] [PATCH 0/9] virtio-blk: multiqueue support, Christian Borntraeger, 2016/05/24
- [Qemu-devel] [RFC] virtio-blk: simple multithreaded MQ implementation for bdrv_raw, Roman Pen, 2016/05/27